From: Kory Maincent <kory.maincent@bootlin.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <richardcochran@gmail.com>,
<Parthiban.Veerasooran@microchip.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v5 1/2] net: phy: micrel: Introduce function __lan8814_ptp_probe_once
Date: Fri, 29 Aug 2025 16:33:41 +0200 [thread overview]
Message-ID: <20250829163341.17712e59@kmaincent-XPS-13-7390> (raw)
In-Reply-To: <20250829134836.1024588-2-horatiu.vultur@microchip.com>
On Fri, 29 Aug 2025 15:48:35 +0200
Horatiu Vultur <horatiu.vultur@microchip.com> wrote:
> Introduce the function __lan8814_ptp_probe_once as this function will be
> used also by lan8842 driver. This change doesn't have any functional
> changes.
It would have been nice to add the fact that the lan8842 has a different number
GPIO in the commit message. It would have explained more the why.
Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
Thank you!
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2025-08-29 14:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 13:48 [PATCH net-next v5 0/2] net: phy: micrel: Add PTP support for lan8842 Horatiu Vultur
2025-08-29 13:48 ` [PATCH net-next v5 1/2] net: phy: micrel: Introduce function __lan8814_ptp_probe_once Horatiu Vultur
2025-08-29 14:33 ` Kory Maincent [this message]
2025-09-01 6:16 ` Horatiu Vultur
2025-08-29 13:48 ` [PATCH net-next v5 2/2] net: phy: micrel: Add PTP support for lan8842 Horatiu Vultur
2025-08-29 14:53 ` Kory Maincent
2025-09-01 6:21 ` Horatiu Vultur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250829163341.17712e59@kmaincent-XPS-13-7390 \
--to=kory.maincent@bootlin.com \
--cc=Parthiban.Veerasooran@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox