From: Jakub Kicinski <kuba@kernel.org>
To: Florian Westphal <fw@strlen.de>
Cc: <netdev@vger.kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
<netfilter-devel@vger.kernel.org>,
pablo@netfilter.org
Subject: Re: [PATCH net] netfilter: nft_flowtable.sh: re-run with random mtu sizes
Date: Fri, 29 Aug 2025 18:56:24 -0700 [thread overview]
Message-ID: <20250829185624.16d49050@kernel.org> (raw)
In-Reply-To: <20250828214918.3385-1-fw@strlen.de>
On Thu, 28 Aug 2025 23:49:18 +0200 Florian Westphal wrote:
> But all logs I saw show same scenario:
> 1. Failing tests have pmtu discovery off (i.e., ip fragmentation)
> 2. The test file is much larger than first-pass default (2M Byte)
> 3. peers have much larger MTUs compared to the 'network'.
>
> These errors are very reproducible when re-running the test with
> the same commandline arguments.
>
> The timeout became much more prominent with
> 1d2fbaad7cd8 ("tcp: stronger sk_rcvbuf checks"): reassembled packets
> typically have a skb->truesize more than double the skb length.
>
> As that commit is intentional and pmtud-off with
> large-tcp-packets-as-fragments is not normal adjust the test to use a
> smaller file for the pmtu-off subtests.
>
> While at it, add more information to pass/fail messages and
> also run the dscp alteration subtest with pmtu discovery enabled.
Thank you for fixing!
next prev parent reply other threads:[~2025-08-30 1:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 21:49 [PATCH net] netfilter: nft_flowtable.sh: re-run with random mtu sizes Florian Westphal
2025-08-30 1:56 ` Jakub Kicinski [this message]
2025-08-30 2:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250829185624.16d49050@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox