[PATCH net-next 0/5] net: phy: remove support for deprecated array-style fixed-link binding

[PATCH net-next 0/5] net: phy: remove support for deprecated array-style fixed-link binding

[Heiner Kallweit]

The array-style fixed-link binding has been marked deprecated for more
than 10 yrs. See e.g. 91c1d980d601 ("Documentation: devicetree: add old
and deprecated 'fixed-link'") from 2014.

So migrate the remaining few in-kernel users of the old binding,
and remove for it.

Heiner Kallweit (5):
  arm64: dts: ls1043a-qds: switch to new fixed-link binding
  ARM: dts: ls1021a: switch to new fixed-link binding
  ARM: dts: st: switch to new fixed-link binding
  net: mdio: remove support for old fixed-link binding
  net: phy: phylink: remove support for deprecated fixed-link-binding

 arch/arm/boot/dts/nxp/ls/ls1021a-iot.dts      |  5 +++-
 arch/arm/boot/dts/st/stih418-b2199.dts        |  5 +++-
 arch/arm/boot/dts/st/stihxxx-b2120.dtsi       |  5 +++-
 .../boot/dts/freescale/fsl-ls1043a-qds.dts    |  5 +++-
 drivers/net/mdio/of_mdio.c                    | 26 -------------------
 drivers/net/phy/phylink.c                     | 25 +-----------------
 6 files changed, 17 insertions(+), 54 deletions(-)

-- 
2.51.0

[PATCH net-next 1/5] arm64: dts: ls1043a-qds: switch to new fixed-link binding

[Heiner Kallweit]

The old array-type fixed-link binding has been deprecated
for more than 10 yrs. Switch to the new binding.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
index e850551b1..2e6fd153f 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
@@ -205,7 +205,10 @@ ethernet@ea000 {
 	};
 
 	ethernet@f0000 { /* DTSEC9/10GEC1 */
-		fixed-link = <1 1 10000 0 0>;
+		fixed-link {
+			speed = <10000>;
+			full-duplex;
+		};
 		phy-connection-type = "xgmii";
 	};
 };
-- 
2.51.0

Re: [PATCH net-next 1/5] arm64: dts: ls1043a-qds: switch to new fixed-link binding

[kernel test robot]

Hi Heiner,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Heiner-Kallweit/arm64-dts-ls1043a-qds-switch-to-new-fixed-link-binding/20250830-183341
base:   net-next/main
patch link:    https://lore.kernel.org/r/fe4c021d-c188-4fc2-8b2f-9c3c269056eb%40gmail.com
patch subject: [PATCH net-next 1/5] arm64: dts: ls1043a-qds: switch to new fixed-link binding
config: arm64-randconfig-002-20250830 (https://download.01.org/0day-ci/archive/20250830/202508302350.uP3JO7bq-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project ac23f7465eedd0dd565ffb201f573e7a69695fa3)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250830/202508302350.uP3JO7bq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508302350.uP3JO7bq-lkp@intel.com/

All errors (new ones prefixed by >>):

>> Error: arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts:212.3-33 Properties must precede subnodes
   FATAL ERROR: Unable to parse input tree

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH net-next 1/5] arm64: dts: ls1043a-qds: switch to new fixed-link binding

[Russell King (Oracle)]

On Sat, Aug 30, 2025 at 12:27:23PM +0200, Heiner Kallweit wrote:
> The old array-type fixed-link binding has been deprecated
> for more than 10 yrs. Switch to the new binding.

... and the fact we have device trees that use it today means that we
can't remove support for it from the kernel.

I think it would make sense to update the dts files, and add a noisy
warning when we detect that it's being used to prevent future usage.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

Re: [PATCH net-next 1/5] arm64: dts: ls1043a-qds: switch to new fixed-link binding

[Heiner Kallweit]

On 8/30/2025 11:27 PM, Russell King (Oracle) wrote:
> On Sat, Aug 30, 2025 at 12:27:23PM +0200, Heiner Kallweit wrote:
>> The old array-type fixed-link binding has been deprecated
>> for more than 10 yrs. Switch to the new binding.
> 
> ... and the fact we have device trees that use it today means that we
> can't remove support for it from the kernel.
> 
After this series there is no in-tree user of the old binding any longer.
So why shouldn't we remove support for the old binding?
Do you think of out-of-tree users, or of new dts files using the
old binding?

> I think it would make sense to update the dts files, and add a noisy
> warning when we detect that it's being used to prevent future usage.
> 

The old binding is marked deprecated in the schema, not sure whether
this results in any warning.

  fixed-link:
    oneOf:
      - $ref: /schemas/types.yaml#/definitions/uint32-array
        deprecated: true

Re: [PATCH net-next 1/5] arm64: dts: ls1043a-qds: switch to new fixed-link binding

[Russell King (Oracle)]

On Sat, Aug 30, 2025 at 11:39:58PM +0200, Heiner Kallweit wrote:
> On 8/30/2025 11:27 PM, Russell King (Oracle) wrote:
> > On Sat, Aug 30, 2025 at 12:27:23PM +0200, Heiner Kallweit wrote:
> >> The old array-type fixed-link binding has been deprecated
> >> for more than 10 yrs. Switch to the new binding.
> > 
> > ... and the fact we have device trees that use it today means that we
> > can't remove support for it from the kernel.
> > 
> After this series there is no in-tree user of the old binding any longer.

Doesn't matter. Please read Documentation/devicetree/bindings/ABI.rst
particularly the but about "newer kernel will not break on an older
device tree".

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

Re: [PATCH net-next 1/5] arm64: dts: ls1043a-qds: switch to new fixed-link binding

[Heiner Kallweit]

On 8/30/2025 11:27 PM, Russell King (Oracle) wrote:
> On Sat, Aug 30, 2025 at 12:27:23PM +0200, Heiner Kallweit wrote:
>> The old array-type fixed-link binding has been deprecated
>> for more than 10 yrs. Switch to the new binding.
> 
> ... and the fact we have device trees that use it today means that we
> can't remove support for it from the kernel.
> 
> I think it would make sense to update the dts files, and add a noisy
> warning when we detect that it's being used to prevent future usage.
> 
Usage of the deprecated binding was added to this dt file with ab9d8032dbd0
("arm64: dts: ls1043a-qds: add mmio based mdio-mux support") in 2022.
At that time the binding had been marked deprecated for years already.
I think it would be good if dtc would warn already if a deprecated
binding is detected, so that CI can complain.

Re: [PATCH net-next 1/5] arm64: dts: ls1043a-qds: switch to new fixed-link binding

[Andrew Lunn]

> Usage of the deprecated binding was added to this dt file with ab9d8032dbd0
> ("arm64: dts: ls1043a-qds: add mmio based mdio-mux support") in 2022.
> At that time the binding had been marked deprecated for years already.
> I think it would be good if dtc would warn already if a deprecated
> binding is detected, so that CI can complain.

I don't think the DTC compiler can help. It does not use the .yaml
files. You can compile a dtc file to dtb without any outside help.

What i think we need is 'make dtbs_check', with some additional flags,
like W=2, looking for such deprecated properties being used.

	Andrew

[PATCH net-next 2/5] ARM: dts: ls1021a: switch to new fixed-link binding

[Heiner Kallweit]

The old array-type fixed-link binding has been deprecated
for more than 10 yrs. Switch to the new binding.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 arch/arm/boot/dts/nxp/ls/ls1021a-iot.dts | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/ls/ls1021a-iot.dts b/arch/arm/boot/dts/nxp/ls/ls1021a-iot.dts
index e13ccae62..8d2438498 100644
--- a/arch/arm/boot/dts/nxp/ls/ls1021a-iot.dts
+++ b/arch/arm/boot/dts/nxp/ls/ls1021a-iot.dts
@@ -120,7 +120,10 @@ &enet1 {
 };
 
 &enet2 {
-	fixed-link = <0 1 1000 0 0>;
+	fixed-link {
+		speed = <1000>;
+		full-duplex;
+	};
 	phy-connection-type = "rgmii-id";
 	status = "okay";
 };
-- 
2.51.0

Re: [PATCH net-next 2/5] ARM: dts: ls1021a: switch to new fixed-link binding

[kernel test robot]

Hi Heiner,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Heiner-Kallweit/arm64-dts-ls1043a-qds-switch-to-new-fixed-link-binding/20250830-183341
base:   net-next/main
patch link:    https://lore.kernel.org/r/7427825b-7d2f-4edb-a357-fa5eabb6d7d7%40gmail.com
patch subject: [PATCH net-next 2/5] ARM: dts: ls1021a: switch to new fixed-link binding
config: arm-randconfig-003-20250830 (https://download.01.org/0day-ci/archive/20250830/202508302318.rMGYiqni-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250830/202508302318.rMGYiqni-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508302318.rMGYiqni-lkp@intel.com/

All errors (new ones prefixed by >>):

>> Error: arch/arm/boot/dts/nxp/ls/ls1021a-iot.dts:127.2-35 Properties must precede subnodes
   FATAL ERROR: Unable to parse input tree

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

[PATCH net-next 3/5] ARM: dts: st: switch to new fixed-link binding

[Heiner Kallweit]

The old array-type fixed-link binding has been deprecated
for more than 10 yrs. Switch to the new binding.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 arch/arm/boot/dts/st/stih418-b2199.dts  | 5 ++++-
 arch/arm/boot/dts/st/stihxxx-b2120.dtsi | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/st/stih418-b2199.dts b/arch/arm/boot/dts/st/stih418-b2199.dts
index 53ac6c2b7..5231222b7 100644
--- a/arch/arm/boot/dts/st/stih418-b2199.dts
+++ b/arch/arm/boot/dts/st/stih418-b2199.dts
@@ -103,7 +103,10 @@ ethernet0: dwmac@9630000 {
 			st,tx-retime-src = "clkgen";
 			status = "okay";
 			phy-mode = "rgmii";
-			fixed-link = <0 1 1000 0 0>;
+			fixed-link {
+				speed = <1000>;
+				full-duplex;
+			};
 		};
 	};
 };
diff --git a/arch/arm/boot/dts/st/stihxxx-b2120.dtsi b/arch/arm/boot/dts/st/stihxxx-b2120.dtsi
index 8d9a2dfa7..f45c65544 100644
--- a/arch/arm/boot/dts/st/stihxxx-b2120.dtsi
+++ b/arch/arm/boot/dts/st/stihxxx-b2120.dtsi
@@ -147,7 +147,10 @@ ethernet0: dwmac@9630000 {
 			st,tx-retime-src = "clkgen";
 			status = "okay";
 			phy-mode = "rgmii";
-			fixed-link = <0 1 1000 0 0>;
+			fixed-link {
+				speed = <1000>;
+				full-duplex;
+			};
 		};
 
 		demux@8a20000 {
-- 
2.51.0

[PATCH net-next 4/5] net: mdio: remove support for old fixed-link binding

[Heiner Kallweit]

The old array-type fixed-link binding has been deprecated
for more than 10 yrs. So remove support for it.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/mdio/of_mdio.c | 26 --------------------------
 1 file changed, 26 deletions(-)

diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c
index d8ca63ed8..5df01717a 100644
--- a/drivers/net/mdio/of_mdio.c
+++ b/drivers/net/mdio/of_mdio.c
@@ -379,21 +379,12 @@ struct phy_device *of_phy_get_and_connect(struct net_device *dev,
 }
 EXPORT_SYMBOL(of_phy_get_and_connect);
 
-/*
- * of_phy_is_fixed_link() and of_phy_register_fixed_link() must
- * support two DT bindings:
- * - the old DT binding, where 'fixed-link' was a property with 5
- *   cells encoding various information about the fixed PHY
- * - the new DT binding, where 'fixed-link' is a sub-node of the
- *   Ethernet device.
- */
 bool of_phy_is_fixed_link(struct device_node *np)
 {
 	struct device_node *dn;
 	int err;
 	const char *managed;
 
-	/* New binding */
 	dn = of_get_child_by_name(np, "fixed-link");
 	if (dn) {
 		of_node_put(dn);
@@ -404,10 +395,6 @@ bool of_phy_is_fixed_link(struct device_node *np)
 	if (err == 0 && strcmp(managed, "auto") != 0)
 		return true;
 
-	/* Old binding */
-	if (of_property_count_u32_elems(np, "fixed-link") == 5)
-		return true;
-
 	return false;
 }
 EXPORT_SYMBOL(of_phy_is_fixed_link);
@@ -416,7 +403,6 @@ int of_phy_register_fixed_link(struct device_node *np)
 {
 	struct fixed_phy_status status = {};
 	struct device_node *fixed_link_node;
-	u32 fixed_link_prop[5];
 	const char *managed;
 
 	if (of_property_read_string(np, "managed", &managed) == 0 &&
@@ -425,7 +411,6 @@ int of_phy_register_fixed_link(struct device_node *np)
 		goto register_phy;
 	}
 
-	/* New binding */
 	fixed_link_node = of_get_child_by_name(np, "fixed-link");
 	if (fixed_link_node) {
 		status.link = 1;
@@ -444,17 +429,6 @@ int of_phy_register_fixed_link(struct device_node *np)
 		goto register_phy;
 	}
 
-	/* Old binding */
-	if (of_property_read_u32_array(np, "fixed-link", fixed_link_prop,
-				       ARRAY_SIZE(fixed_link_prop)) == 0) {
-		status.link = 1;
-		status.duplex = fixed_link_prop[1];
-		status.speed  = fixed_link_prop[2];
-		status.pause  = fixed_link_prop[3];
-		status.asym_pause = fixed_link_prop[4];
-		goto register_phy;
-	}
-
 	return -ENODEV;
 
 register_phy:
-- 
2.51.0

[PATCH net-next 5/5] net: phy: phylink: remove support for deprecated fixed-link binding

[Heiner Kallweit]

The old array-type fixed-link binding has been deprecated
for more than 10 yrs. So remove support for it.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/phy/phylink.c | 25 +------------------------
 1 file changed, 1 insertion(+), 24 deletions(-)

diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index c7f867b36..e3e22e013 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -690,29 +690,6 @@ static int phylink_parse_fixedlink(struct phylink *pl,
 
 		if (ret)
 			return ret;
-	} else {
-		u32 prop[5];
-
-		ret = fwnode_property_read_u32_array(fwnode, "fixed-link",
-						     NULL, 0);
-		if (ret != ARRAY_SIZE(prop)) {
-			phylink_err(pl, "broken fixed-link?\n");
-			return -EINVAL;
-		}
-
-		ret = fwnode_property_read_u32_array(fwnode, "fixed-link",
-						     prop, ARRAY_SIZE(prop));
-		if (!ret) {
-			pl->link_config.duplex = prop[1] ?
-						DUPLEX_FULL : DUPLEX_HALF;
-			pl->link_config.speed = prop[2];
-			if (prop[3])
-				__set_bit(ETHTOOL_LINK_MODE_Pause_BIT,
-					  pl->link_config.lp_advertising);
-			if (prop[4])
-				__set_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
-					  pl->link_config.lp_advertising);
-		}
 	}
 
 	if (pl->link_config.speed > SPEED_1000 &&
@@ -768,7 +745,7 @@ static int phylink_parse_mode(struct phylink *pl,
 		pl->cfg_link_an_mode = MLO_AN_INBAND;
 
 	dn = fwnode_get_named_child_node(fwnode, "fixed-link");
-	if (dn || fwnode_property_present(fwnode, "fixed-link"))
+	if (dn)
 		pl->cfg_link_an_mode = MLO_AN_FIXED;
 	fwnode_handle_put(dn);
 
-- 
2.51.0