From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net] net: phy: fix phy_uses_state_machine()
Date: Mon, 1 Sep 2025 17:25:33 +0300 [thread overview]
Message-ID: <20250901142533.p6wplnjnsnfz2xrn@skbuf> (raw)
In-Reply-To: <aLWqWeGvMM350dB2@shell.armlinux.org.uk>
On Mon, Sep 01, 2025 at 03:14:49PM +0100, Russell King (Oracle) wrote:
> On Mon, Sep 01, 2025 at 01:36:24PM +0300, Vladimir Oltean wrote:
> > The new explanation and the placement of the function pointer clearing
> > make sense, thanks. Maybe add one last sentence at the end: "This covers
> > both the phylink_bringup_phy() error path, as well as the normal
> > phylink_disconnect_phy() path."
>
> Is it really necessary to add that level of detail? phy_attach() sets
> phydev->phy_link_change, so it's natural that phy_detach() should undo
> that action, especially as phy_detach() is phy_attach()'s complement.
Well, it shows for future reference the code paths you've considered
when establishing the placement of the code. Your call whether you want
to include this sentence or not - and it looks like you don't want to.
next prev parent reply other threads:[~2025-09-01 14:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-31 16:38 [PATCH net] net: phy: fix phy_uses_state_machine() Russell King (Oracle)
2025-09-01 8:09 ` Vladimir Oltean
2025-09-01 8:42 ` Vladimir Oltean
2025-09-01 9:09 ` Russell King (Oracle)
2025-09-01 9:35 ` Vladimir Oltean
2025-09-01 10:05 ` Russell King (Oracle)
2025-09-01 10:36 ` Vladimir Oltean
2025-09-01 14:14 ` Russell King (Oracle)
2025-09-01 14:25 ` Vladimir Oltean [this message]
2025-09-01 9:34 ` Russell King (Oracle)
2025-09-01 9:39 ` Vladimir Oltean
2025-09-01 10:23 ` Russell King (Oracle)
-- strict thread matches above, loose matches on Subject: below --
2025-09-07 20:44 Russell King (Oracle)
2025-09-08 13:37 ` Vladimir Oltean
2025-09-09 23:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250901142533.p6wplnjnsnfz2xrn@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox