From: Rosen Penev <rosenp@gmail.com>
To: netdev@vger.kernel.org
Cc: Horatiu Vultur <horatiu.vultur@microchip.com>,
UNGLinuxDriver@microchip.com (maintainer:MICROCHIP LAN966X
ETHERNET DRIVER), Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk> (maintainer:SFF/SFP/SFP+
MODULE SUPPORT:Keyword:phylink\.h|struct\s+phylink|\.phylink|>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCHv2 net-next 1/2] net: lan966x: use of_get_mac_address
Date: Mon, 1 Sep 2025 13:20:00 -0700 [thread overview]
Message-ID: <20250901202001.27024-2-rosenp@gmail.com> (raw)
In-Reply-To: <20250901202001.27024-1-rosenp@gmail.com>
As lan966x is an OF driver, switching to the OF version allows usage of
NVMEM to override the MAC address of the interface.
Handle EPROBE_DEFER in the case that NVMEM loads after lan966x.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/ethernet/microchip/lan966x/lan966x_main.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
index 7001584f1b7a..8bf28915c030 100644
--- a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
+++ b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
@@ -1083,7 +1083,6 @@ static int lan966x_probe(struct platform_device *pdev)
{
struct fwnode_handle *ports, *portnp;
struct lan966x *lan966x;
- u8 mac_addr[ETH_ALEN];
int err;
lan966x = devm_kzalloc(&pdev->dev, sizeof(*lan966x), GFP_KERNEL);
@@ -1093,9 +1092,11 @@ static int lan966x_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, lan966x);
lan966x->dev = &pdev->dev;
- if (!device_get_mac_address(&pdev->dev, mac_addr)) {
- ether_addr_copy(lan966x->base_mac, mac_addr);
- } else {
+ err = of_get_mac_address(pdev->dev.of_node, lan966x->base_mac);
+ if (err == -EPROBE_DEFER)
+ return err;
+
+ if (err) {
pr_info("MAC addr was not set, use random MAC\n");
eth_random_addr(lan966x->base_mac);
lan966x->base_mac[5] &= 0xf0;
--
2.51.0
next prev parent reply other threads:[~2025-09-01 20:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 20:19 [PATCHv2 net-next 0/2] net: lan966x: some OF cleanups Rosen Penev
2025-09-01 20:20 ` Rosen Penev [this message]
2025-09-01 20:20 ` [PATCHv2 net-next 2/2] net: lan966x: convert fwnode to of Rosen Penev
2025-09-03 23:55 ` Jakub Kicinski
2025-09-04 1:04 ` Rosen Penev
2025-09-04 9:00 ` Daniel Machon
2025-09-04 20:30 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250901202001.27024-2-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).