From: Simon Horman <horms@kernel.org>
To: Mahanta Jambigi <mjambigi@linux.ibm.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, alibuda@linux.alibaba.com,
dust.li@linux.alibaba.com, sidraya@linux.ibm.com,
wenjia@linux.ibm.com, pasic@linux.ibm.com,
tonylu@linux.alibaba.com, guwen@linux.alibaba.com,
netdev@vger.kernel.org, linux-s390@vger.kernel.org,
linux-rdma@vger.kernel.org,
Alexandra Winter <wintera@linux.ibm.com>
Subject: Re: [PATCH net] net/smc: Remove validation of reserved bits in CLC Decline message
Date: Tue, 2 Sep 2025 08:08:31 +0100 [thread overview]
Message-ID: <20250902070831.GA168966@horms.kernel.org> (raw)
In-Reply-To: <20250829102626.3271637-1-mjambigi@linux.ibm.com>
On Fri, Aug 29, 2025 at 12:26:26PM +0200, Mahanta Jambigi wrote:
> Currently SMC code is validating the reserved bits while parsing the incoming
> CLC decline message & when this validation fails, its treated as a protocol
> error. As a result, the SMC connection is terminated instead of falling back to
> TCP. As per RFC7609[1] specs we shouldn't be validating the reserved bits that
> is part of CLC message. This patch fixes this issue.
>
> CLC Decline message format can viewed here[2].
>
> [1] https://datatracker.ietf.org/doc/html/rfc7609#page-92
> [2] https://datatracker.ietf.org/doc/html/rfc7609#page-105
>
> Fixes: 8ade200(net/smc: add v2 format of CLC decline message)
>
Hi Mahanta,
Sorry to nit-pick, but there should not be a blank line here.
And the correct format for the Fixes tag, whith at least
12 characters of hash, is:
Fixes: 8ade200c269f ("net/smc: add v2 format of CLC decline message")
> Signed-off-by: Mahanta Jambigi <mjambigi@linux.ibm.com>
> Reference-ID: LTC214332
Please drop this non-standard tag.
And please only include references (by any means) to public information.
> Reviewed-by: Sidraya Jayagond <sidraya@linux.ibm.com>
> Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
...
next prev parent reply other threads:[~2025-09-02 7:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 10:26 [PATCH net] net/smc: Remove validation of reserved bits in CLC Decline message Mahanta Jambigi
2025-08-29 14:58 ` Dust Li
2025-09-01 6:12 ` Mahanta Jambigi
2025-09-02 4:08 ` Dust Li
2025-09-02 6:05 ` Mahanta Jambigi
2025-09-02 7:26 ` Dust Li
2025-09-02 7:08 ` Simon Horman [this message]
2025-09-02 8:13 ` Mahanta Jambigi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250902070831.GA168966@horms.kernel.org \
--to=horms@kernel.org \
--cc=alibuda@linux.alibaba.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjambigi@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=sidraya@linux.ibm.com \
--cc=tonylu@linux.alibaba.com \
--cc=wenjia@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).