From: Jakub Kicinski <kuba@kernel.org>
To: Carolina Jubran <cjubran@nvidia.com>
Cc: Shuah Khan <shuah@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Gal Pressman <gal@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>,
"Cosmin Ratiu" <cratiu@nvidia.com>,
Nimrod Oren <noren@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
<linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH 3/3] selftests: drv-net: Relax total BW check in devlink_rate_tc_bw.py
Date: Tue, 2 Sep 2025 16:21:01 -0700 [thread overview]
Message-ID: <20250902162101.5c78cc88@kernel.org> (raw)
In-Reply-To: <20250831080641.1828455-4-cjubran@nvidia.com>
On Sun, 31 Aug 2025 11:06:41 +0300 Carolina Jubran wrote:
> Because the measured total is the sum of two iperf3 streams that do not
> always start or stop at the same time
That's solvable, tho? iperf3 has --json support, it will give you
the b/w readings in the configured intervals (1sec by default).
With the interval based samples at hand you should be able to select
only the period in which b/w is stable ("middle" of the test).
While at it it may make sense to switch to lib/py/load.py wrappers
rather than threading the python locally in the test.
next prev parent reply other threads:[~2025-09-02 23:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-31 8:06 [PATCH 0/3] selftests: drv-net: Fix issues in devlink_rate_tc_bw.py Carolina Jubran
2025-08-31 8:06 ` [PATCH 1/3] selftests: drv-net: Fix and clarify TC bandwidth split " Carolina Jubran
2025-09-01 15:45 ` Simon Horman
2025-08-31 8:06 ` [PATCH 2/3] selftests: drv-net: Fix tolerance calculation " Carolina Jubran
2025-09-01 15:45 ` Simon Horman
2025-08-31 8:06 ` [PATCH 3/3] selftests: drv-net: Relax total BW check " Carolina Jubran
2025-09-01 15:46 ` Simon Horman
2025-09-02 23:21 ` Jakub Kicinski [this message]
2025-09-05 22:32 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250902162101.5c78cc88@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=noren@nvidia.com \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).