* [PATCH net] net: libwx: fix to enable RSS
@ 2025-09-02 2:57 Jiawen Wu
2025-09-02 11:33 ` Simon Horman
2025-09-03 0:42 ` Jakub Kicinski
0 siblings, 2 replies; 3+ messages in thread
From: Jiawen Wu @ 2025-09-02 2:57 UTC (permalink / raw)
To: netdev, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Simon Horman
Cc: Mengyuan Lou, Jiawen Wu, stable
When SRIOV is enabled, RSS is also supported for the functions. There is
an incorrect flag judgement which causes RSS to fail to be enabled.
Fixes: c52d4b898901 ("net: libwx: Redesign flow when sriov is enabled")
Cc: stable@vger.kernel.org
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
drivers/net/ethernet/wangxun/libwx/wx_hw.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/wangxun/libwx/wx_hw.c b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
index bcd07a715752..5cb353a97d6d 100644
--- a/drivers/net/ethernet/wangxun/libwx/wx_hw.c
+++ b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
@@ -2078,10 +2078,6 @@ static void wx_setup_mrqc(struct wx *wx)
{
u32 rss_field = 0;
- /* VT, and RSS do not coexist at the same time */
- if (test_bit(WX_FLAG_VMDQ_ENABLED, wx->flags))
- return;
-
/* Disable indicating checksum in descriptor, enables RSS hash */
wr32m(wx, WX_PSR_CTL, WX_PSR_CTL_PCSD, WX_PSR_CTL_PCSD);
--
2.48.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] net: libwx: fix to enable RSS
2025-09-02 2:57 [PATCH net] net: libwx: fix to enable RSS Jiawen Wu
@ 2025-09-02 11:33 ` Simon Horman
2025-09-03 0:42 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2025-09-02 11:33 UTC (permalink / raw)
To: Jiawen Wu
Cc: netdev, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Mengyuan Lou, stable
On Tue, Sep 02, 2025 at 10:57:13AM +0800, Jiawen Wu wrote:
> When SRIOV is enabled, RSS is also supported for the functions. There is
> an incorrect flag judgement which causes RSS to fail to be enabled.
>
> Fixes: c52d4b898901 ("net: libwx: Redesign flow when sriov is enabled")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] net: libwx: fix to enable RSS
2025-09-02 2:57 [PATCH net] net: libwx: fix to enable RSS Jiawen Wu
2025-09-02 11:33 ` Simon Horman
@ 2025-09-03 0:42 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2025-09-03 0:42 UTC (permalink / raw)
To: Jiawen Wu
Cc: netdev, Andrew Lunn, David S. Miller, Eric Dumazet, Paolo Abeni,
Simon Horman, Mengyuan Lou, stable
On Tue, 2 Sep 2025 10:57:13 +0800 Jiawen Wu wrote:
> When SRIOV is enabled, RSS is also supported for the functions. There is
> an incorrect flag judgement which causes RSS to fail to be enabled.
Please describe user-visible behavior. Does it mean that VF with
multiple queues will receive all traffic on queue 0?
--
pw-bot: cr
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-03 0:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-02 2:57 [PATCH net] net: libwx: fix to enable RSS Jiawen Wu
2025-09-02 11:33 ` Simon Horman
2025-09-03 0:42 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).