From: Jakub Kicinski <kuba@kernel.org>
To: Marc Harvey <marcharvey@google.com>
Cc: jiri@resnulli.us, andrew+netdev@lunn.ch, edumazet@google.com,
willemb@google.com, maheshb@google.com, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: net: Add tests to verify team driver option set and get.
Date: Wed, 3 Sep 2025 06:59:57 -0700 [thread overview]
Message-ID: <20250903065957.3ebfcb2c@kernel.org> (raw)
In-Reply-To: <CANkEMgnghooTAW-VqodTpwSUHicb6fb6c0mBi1vpxPHnSNQccg@mail.gmail.com>
On Tue, 2 Sep 2025 18:01:09 -0700 Marc Harvey wrote:
> I'm aware of the shellcheck errors. Will wait to send v2 tomorrow for
> the 24 hour rule.
This test fails for us, I think you need to also adjust the config
file, please see:
https://github.com/linux-netdev/nipa/wiki/How-to-run-netdev-selftests-CI-style#building-the-kernel
[...]
# Command failed: No such file or directory
# TEST: Get 'fake_option2' fails [ OK ]
# Setting 'mode' to 'activebackup' and 'loadbalance'
# Command failed: Invalid argument
# 'setoption mode activebackup' failed
# Command failed: Invalid argument
# 'setoption mode activebackup' failed
# TEST: Set + Get 'mode' test [FAIL]
# Failed to set 'mode' to 'activebackup'
# Setting 'notify_peers_count' to '0' and '5'
# TEST: Set + Get 'notify_peers_count' test [ OK ]
# Setting 'notify_peers_interval' to '0' and '5'
[...]
https://netdev-3.bots.linux.dev/vmksft-bonding/results/281681/11-options-sh/stdout
next prev parent reply other threads:[~2025-09-03 13:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 23:55 [PATCH net-next] selftests: net: Add tests to verify team driver option set and get Marc Harvey
2025-09-03 1:01 ` Marc Harvey
2025-09-03 13:59 ` Jakub Kicinski [this message]
2025-09-04 1:02 ` Hangbin Liu
2025-09-04 1:17 ` Marc Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903065957.3ebfcb2c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=linux-kselftest@vger.kernel.org \
--cc=maheshb@google.com \
--cc=marcharvey@google.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).