netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Michael Dege <michael.dege@renesas.com>
Cc: "Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
	"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
	"Paul Barker" <paul@pbarker.dev>,
	"Andrew Lunn" <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Nikita Yushchenko" <nikita.yoush@cogentembedded.com>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
	"Jiri Pirko" <jiri@resnulli.us>,
	"Ivan Vecera" <ivecera@redhat.com>
Subject: Re: [net-next PATCH v5 0/4] net: renesas: rswitch: R-Car S4 add HW offloading for layer 2 switching
Date: Wed, 3 Sep 2025 16:50:41 -0700	[thread overview]
Message-ID: <20250903165041.20b3c05e@kernel.org> (raw)
In-Reply-To: <20250901-add_l2_switching-v5-0-5f13e46860d5@renesas.com>

On Mon, 01 Sep 2025 06:58:04 +0200 Michael Dege wrote:
> The current R-Car S4 rswitch driver only supports port based fowarding.
> This patch set adds HW offloading for L2 switching/bridgeing. The driver
> hooks into switchdev.
> 
> 1. Rename the base driver file to keep the driver name (rswitch.ko)
> 
> 2. Add setting of default MAC ageing time in hardware.
> 
> 3. Add the L2 driver extension in a separate file. The HW offloading
> is automatically configured when a port is added to the bridge device.
> 
> Usage example:
> ip link add name br0 type bridge
> ip link set dev tsn0 master br0
> ip link set dev tsn1 master br0
> ip link set dev br0 up
> ip link set dev tsn0 up
> ip link set dev tsn1 up
> 
> Layer 2 traffic is now fowarded by HW from port TSN0 to port TSN1.
> 
> 4. Provides the functionality to set the MAC table ageing time in the
> Rswitch.

Is anyone with bride offload expertise willing to provide a review here?


Jiri, Ivan, the switchdev MAINTAINERS entry only covers "core" switchdev
which is rather fallow. Is it okay to extend it to driver review?

  parent reply	other threads:[~2025-09-03 23:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-01  4:58 [net-next PATCH v5 0/4] net: renesas: rswitch: R-Car S4 add HW offloading for layer 2 switching Michael Dege
2025-09-01  4:58 ` [PATCH net-next v5 1/4] net: renesas: rswitch: rename rswitch.c to rswitch_main.c Michael Dege
2025-09-01  4:58 ` [PATCH net-next v5 2/4] net: renesas: rswitch: configure default ageing time Michael Dege
2025-09-01  4:58 ` [PATCH net-next v5 3/4] net: renesas: rswitch: add offloading for L2 switching Michael Dege
2025-09-01  4:58 ` [PATCH net-next v5 4/4] net: renesas: rswitch: add modifiable ageing time Michael Dege
2025-09-03 23:50 ` Jakub Kicinski [this message]
2025-09-04  8:10 ` [net-next PATCH v5 0/4] net: renesas: rswitch: R-Car S4 add HW offloading for layer 2 switching patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250903165041.20b3c05e@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=ivecera@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=michael.dege@renesas.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikita.yoush@cogentembedded.com \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=niklas.soderlund@ragnatech.se \
    --cc=pabeni@redhat.com \
    --cc=paul@pbarker.dev \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).