From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, asantostc@gmail.com,
efault@gmx.de, calvin@wbinvd.org, kernel-team@meta.com
Subject: Re: [PATCH net-next] selftest: netcons: create a torture test
Date: Wed, 3 Sep 2025 17:37:46 -0700 [thread overview]
Message-ID: <20250903173746.5c04c306@kernel.org> (raw)
In-Reply-To: <20250902-netconsole_torture-v1-1-03c6066598e9@debian.org>
On Tue, 02 Sep 2025 09:33:33 -0700 Breno Leitao wrote:
> Create a netconsole test that puts a lot of pressure on the netconsole
> list manipulation. Do it by creating dynamic targets and deleting
> targets while messages are being sent. Also put interface down while the
> messages are being sent, as creating parallel targets.
>
> The code launches three background jobs on distinct schedules:
>
> * Toggle netcons target every 30 iterations
> * create and delete random_target every 50 iterations
> * toggle iface every 70 iterations
>
> This creates multiple concurrency sources that interact with netconsole
> states. This is good practice to simulate stress, and exercise netpoll
> and netconsole locks.
Oh, when you said "selftest will be posted later" in the fix I thought
you meant days, not hours later :) It's better if the fix and test are
in one series. Better for backports, and it avoid situations like last
night when the fix was already dropped from pw but this test was still
running (and crashing the kernel).
Regarding the test, I think it makes sense. Tho is there a way we can
reuse more of the existing code? Do you write all these scripts by hand
or get AI to write them? I was hoping you'd add more tests relating to
bonding. To confirm bonding still works. And as I mentioned I think
bonding is still a bit buggy if we "propagate" multiple nps and then
remove them out of order..
next prev parent reply other threads:[~2025-09-04 0:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 16:33 [PATCH net-next] selftest: netcons: create a torture test Breno Leitao
2025-09-04 0:37 ` Jakub Kicinski [this message]
2025-09-04 8:13 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903173746.5c04c306@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=asantostc@gmail.com \
--cc=calvin@wbinvd.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=efault@gmx.de \
--cc=kernel-team@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).