* [PATCH] macsec: fix double free of flow_table groups on allocation failure
@ 2025-09-04 11:46 Makar Semyonov
2025-09-04 13:44 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Makar Semyonov @ 2025-09-04 11:46 UTC (permalink / raw)
To: Saeed Mahameed
Cc: Makar Semyonov, Leon Romanovsky, Tariq Toukan, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Sabrina Dubroca, netdev, linux-rdma, linux-kernel
In macsec_fs_rx_create_crypto_table_groups(), when memory allocation
for 'in' fails, 'ft->g' is cleared once. However, the function
returns a non-zero error which causes macsec_fs_rx_destroy to be called.
Inside it, macsec_fs_destroy_flow_table is invoked, which attempts
to clear 'ft->g' again, leading to a double free.
This commit fixes the issue by setting 'ft->g' to NULL immediately
after the first clearance in macsec_fs_rx_create_crypto_table_groups()
to prevent a double free when macsec_fs_destroy_flow_table attempts
to free it again.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Makar Semyonov <m.semenov@tssltd.ru>
---
drivers/net/ethernet/mellanox/mlx5/core/lib/macsec_fs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/macsec_fs.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/macsec_fs.c
index 4a078113e292..5e86c277f33a 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/lib/macsec_fs.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/macsec_fs.c
@@ -1066,6 +1066,7 @@ static int macsec_fs_rx_create_crypto_table_groups(struct mlx5_macsec_flow_table
in = kvzalloc(inlen, GFP_KERNEL);
if (!in) {
kfree(ft->g);
+ ft->g = NULL;
return -ENOMEM;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] macsec: fix double free of flow_table groups on allocation failure
2025-09-04 11:46 [PATCH] macsec: fix double free of flow_table groups on allocation failure Makar Semyonov
@ 2025-09-04 13:44 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2025-09-04 13:44 UTC (permalink / raw)
To: Makar Semyonov
Cc: Saeed Mahameed, Leon Romanovsky, Tariq Toukan, Andrew Lunn,
David S. Miller, Eric Dumazet, Paolo Abeni, Sabrina Dubroca,
netdev, linux-rdma, linux-kernel
On Thu, 4 Sep 2025 14:46:54 +0300 Makar Semyonov wrote:
> Subject: [PATCH] macsec: fix double free of flow_table groups on allocation failure
nit: please use the driver name as the first prefix, so "mlx5:" or
"eth: mlx5:". "macsec:" would be appropriate for drivers/net/macsec
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-04 13:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-04 11:46 [PATCH] macsec: fix double free of flow_table groups on allocation failure Makar Semyonov
2025-09-04 13:44 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).