From: Simon Horman <horms@kernel.org>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: dsahern@kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] udp_tunnel: Fix typo using netdev_WARN instead of netdev_warn
Date: Thu, 4 Sep 2025 10:18:32 +0100 [thread overview]
Message-ID: <20250904091832.GC372207@horms.kernel.org> (raw)
In-Reply-To: <20250903195717.2614214-1-alok.a.tiwari@oracle.com>
On Wed, Sep 03, 2025 at 12:57:12PM -0700, Alok Tiwari wrote:
> There is no condition being tested, so it should be netdev_warn,
> not netdev_WARN. Using netdev_WARN here is a typo or misuse.
Hi Alok,
I agree that using netdev_warn() seems more appropriate.
But doesn't the difference between netdev_warn() and netdev_WARN()
lie in the output they produce rather than testing of a condition
(or not)?
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
...
next prev parent reply other threads:[~2025-09-04 9:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 19:57 [PATCH net-next] udp_tunnel: Fix typo using netdev_WARN instead of netdev_warn Alok Tiwari
2025-09-04 9:18 ` Simon Horman [this message]
2025-09-04 13:45 ` [External] : " ALOK TIWARI
2025-09-04 14:28 ` Jakub Kicinski
2025-09-04 14:41 ` ALOK TIWARI
2025-09-04 15:52 ` Jakub Kicinski
2025-09-04 18:48 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250904091832.GC372207@horms.kernel.org \
--to=horms@kernel.org \
--cc=alok.a.tiwari@oracle.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).