From: Simon Horman <horms@kernel.org>
To: alistair23@gmail.com
Cc: chuck.lever@oracle.com, hare@kernel.org,
kernel-tls-handshake@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-nfs@vger.kernel.org,
kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
kch@nvidia.com, Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH v2 7/7] nvmet-tcp: Support KeyUpdate
Date: Fri, 5 Sep 2025 14:25:43 +0100 [thread overview]
Message-ID: <20250905132543.GG553991@horms.kernel.org> (raw)
In-Reply-To: <20250905024659.811386-8-alistair.francis@wdc.com>
On Fri, Sep 05, 2025 at 12:46:59PM +1000, alistair23@gmail.com wrote:
...
> diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c
...
> static int nvmet_tcp_tls_record_ok(struct nvmet_tcp_queue *queue,
> struct msghdr *msg, char *cbuf)
> {
> struct cmsghdr *cmsg = (struct cmsghdr *)cbuf;
> - u8 ctype, level, description;
> + u8 ctype, htype, level, description;
nit: htype is unused in this function
Flagged by W=1 builds.
> int ret = 0;
>
> ctype = tls_get_record_type(queue->sock->sk, cmsg);
...
next prev parent reply other threads:[~2025-09-05 13:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 2:46 [PATCH v2 0/7] nvme-tcp: Support receiving KeyUpdate requests alistair23
2025-09-05 2:46 ` [PATCH v2 1/7] net/handshake: Store the key serial number on completion alistair23
2025-09-05 13:18 ` Simon Horman
2025-09-05 2:46 ` [PATCH v2 2/7] net/handshake: Make handshake_req_cancel public alistair23
2025-09-05 14:11 ` kernel test robot
2025-09-05 2:46 ` [PATCH v2 3/7] net/handshake: Expose handshake_sk_destruct_req publically alistair23
2025-09-05 2:46 ` [PATCH v2 4/7] nvmet: Expose nvmet_stop_keep_alive_timer publically alistair23
2025-09-05 2:46 ` [PATCH v2 5/7] net/handshake: Support KeyUpdate message types alistair23
2025-09-05 13:23 ` Simon Horman
2025-09-05 2:46 ` [PATCH v2 6/7] nvme-tcp: Support KeyUpdate alistair23
2025-09-16 13:04 ` Hannes Reinecke
2025-09-17 3:14 ` Alistair Francis
2025-09-17 10:12 ` Hannes Reinecke
2025-09-17 10:56 ` Alistair Francis
2025-09-05 2:46 ` [PATCH v2 7/7] nvmet-tcp: " alistair23
2025-09-05 5:52 ` Maurizio Lombardi
2025-09-05 13:19 ` Maurizio Lombardi
2025-09-05 13:25 ` Simon Horman [this message]
2025-09-05 14:01 ` kernel test robot
2025-09-15 11:44 ` [PATCH v2 0/7] nvme-tcp: Support receiving KeyUpdate requests Hannes Reinecke
2025-09-15 16:31 ` Olga Kornievskaia
2025-09-16 0:50 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250905132543.GG553991@horms.kernel.org \
--to=horms@kernel.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=axboe@kernel.dk \
--cc=chuck.lever@oracle.com \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=kernel-tls-handshake@lists.linux.dev \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).