From: Jakub Kicinski <kuba@kernel.org>
To: Shenwei Wang <shenwei.wang@nxp.com>
Cc: Wei Fang <wei.fang@nxp.com>, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Clark Wang <xiaoning.wang@nxp.com>,
Stanislav Fomichev <sdf@fomichev.me>,
imx@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-imx@nxp.com,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v5 net-next 2/5] net: fec: add pagepool_order to support variable page size
Date: Fri, 5 Sep 2025 18:52:07 -0700 [thread overview]
Message-ID: <20250905185207.2285900d@kernel.org> (raw)
In-Reply-To: <20250904203502.403058-3-shenwei.wang@nxp.com>
On Thu, 4 Sep 2025 15:34:59 -0500 Shenwei Wang wrote:
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index 5a21000aca59..f046d32a62fb 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -1780,7 +1780,7 @@ fec_enet_rx_queue(struct net_device *ndev, u16 queue_id, int budget)
> * These get messed up if we get called due to a busy condition.
> */
> bdp = rxq->bd.cur;
> - xdp_init_buff(&xdp, PAGE_SIZE, &rxq->xdp_rxq);
> + xdp_init_buff(&xdp, (PAGE_SIZE << fep->pagepool_order), &rxq->xdp_rxq);
please drop the unnecessary parenthesis, and
> while (!((status = fec16_to_cpu(bdp->cbd_sc)) & BD_ENET_RX_EMPTY)) {
>
> @@ -1850,7 +1850,7 @@ fec_enet_rx_queue(struct net_device *ndev, u16 queue_id, int budget)
> * include that when passing upstream as it messes up
> * bridging applications.
> */
> - skb = build_skb(page_address(page), PAGE_SIZE);
> + skb = build_skb(page_address(page), (PAGE_SIZE << fep->pagepool_order));
wrap the lines at 80 chars
next prev parent reply other threads:[~2025-09-06 1:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 20:34 [PATCH v5 net-next 0/5] net: fec: add the Jumbo frame support Shenwei Wang
2025-09-04 20:34 ` [PATCH v5 net-next 1/5] net: fec: use a member variable for maximum buffer size Shenwei Wang
2025-09-04 21:02 ` Frank Li
2025-09-06 1:49 ` Jakub Kicinski
2025-09-04 20:34 ` [PATCH v5 net-next 2/5] net: fec: add pagepool_order to support variable page size Shenwei Wang
2025-09-04 21:03 ` Frank Li
2025-09-06 1:52 ` Jakub Kicinski [this message]
2025-09-04 20:35 ` [PATCH v5 net-next 3/5] net: fec: add rx_frame_size to support configurable RX length Shenwei Wang
2025-09-04 21:13 ` Frank Li
2025-09-04 20:35 ` [PATCH v5 net-next 4/5] net: fec: add change_mtu to support dynamic buffer allocation Shenwei Wang
2025-09-04 21:37 ` Frank Li
2025-09-06 1:56 ` Jakub Kicinski
2025-09-04 20:35 ` [PATCH v5 net-next 5/5] net: fec: enable the Jumbo frame support for i.MX8QM Shenwei Wang
2025-09-04 21:40 ` Frank Li
2025-09-05 20:14 ` Shenwei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250905185207.2285900d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=imx@lists.linux.dev \
--cc=john.fastabend@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).