From: Ido Schimmel <idosch@nvidia.com>
To: <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
<edumazet@google.com>, <horms@kernel.org>, <paul@paul-moore.com>,
<dsahern@kernel.org>, <petrm@nvidia.com>,
<linux-security-module@vger.kernel.org>,
Ido Schimmel <idosch@nvidia.com>
Subject: [PATCH net-next v2 0/8] ipv4: icmp: Fix source IP derivation in presence of VRFs
Date: Mon, 8 Sep 2025 10:32:30 +0300 [thread overview]
Message-ID: <20250908073238.119240-1-idosch@nvidia.com> (raw)
Align IPv4 with IPv6 and in the presence of VRFs generate ICMP error
messages with a source IP that is derived from the receiving interface
and not from its VRF master. This is especially important when the error
messages are "Time Exceeded" messages as it means that utilities like
traceroute will show an incorrect packet path.
Patches #1-#2 are preparations.
Patch #3 is the actual change.
Patches #4-#7 make small improvements in the existing traceroute test.
Patch #8 extends the traceroute test with VRF test cases for both IPv4
and IPv6.
Changes since v1 [1]:
* Rebase.
[1] https://lore.kernel.org/netdev/20250901083027.183468-1-idosch@nvidia.com/
Ido Schimmel (8):
ipv4: cipso: Simplify IP options handling in cipso_v4_error()
ipv4: icmp: Pass IPv4 control block structure as an argument to
__icmp_send()
ipv4: icmp: Fix source IP derivation in presence of VRFs
selftests: traceroute: Return correct value on failure
selftests: traceroute: Use require_command()
selftests: traceroute: Reword comment
selftests: traceroute: Test traceroute with different source IPs
selftests: traceroute: Add VRF tests
include/net/icmp.h | 10 +-
net/ipv4/cipso_ipv4.c | 13 +-
net/ipv4/icmp.c | 15 +-
net/ipv4/route.c | 10 +-
tools/testing/selftests/net/traceroute.sh | 250 ++++++++++++++++++----
5 files changed, 229 insertions(+), 69 deletions(-)
--
2.51.0
next reply other threads:[~2025-09-08 7:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 7:32 Ido Schimmel [this message]
2025-09-08 7:32 ` [PATCH net-next v2 1/8] ipv4: cipso: Simplify IP options handling in cipso_v4_error() Ido Schimmel
2025-09-08 7:51 ` Eric Dumazet
2025-09-08 7:32 ` [PATCH net-next v2 2/8] ipv4: icmp: Pass IPv4 control block structure as an argument to __icmp_send() Ido Schimmel
2025-09-08 7:55 ` Eric Dumazet
2025-09-08 7:32 ` [PATCH net-next v2 3/8] ipv4: icmp: Fix source IP derivation in presence of VRFs Ido Schimmel
2025-09-08 7:32 ` [PATCH net-next v2 4/8] selftests: traceroute: Return correct value on failure Ido Schimmel
2025-09-08 7:32 ` [PATCH net-next v2 5/8] selftests: traceroute: Use require_command() Ido Schimmel
2025-09-08 7:32 ` [PATCH net-next v2 6/8] selftests: traceroute: Reword comment Ido Schimmel
2025-09-08 7:32 ` [PATCH net-next v2 7/8] selftests: traceroute: Test traceroute with different source IPs Ido Schimmel
2025-09-08 7:32 ` [PATCH net-next v2 8/8] selftests: traceroute: Add VRF tests Ido Schimmel
2025-09-11 10:40 ` [PATCH net-next v2 0/8] ipv4: icmp: Fix source IP derivation in presence of VRFs patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250908073238.119240-1-idosch@nvidia.com \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul@paul-moore.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox