From: Jakub Kicinski <kuba@kernel.org>
To: Mina Almasry <almasrymina@google.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
hawk@kernel.org, ilias.apalodimas@linaro.org, nathan@kernel.org,
nick.desaulniers+lkml@gmail.com, morbo@google.com,
justinstitt@google.com, llvm@lists.linux.dev
Subject: Re: [PATCH net-next] page_pool: always add GFP_NOWARN for ATOMIC allocations
Date: Mon, 8 Sep 2025 13:20:41 -0700 [thread overview]
Message-ID: <20250908132041.5ae74626@kernel.org> (raw)
In-Reply-To: <CAHS8izPRupVvCDQr7-GF+-c3yeu83wZWgQth4_ub8bQ0AhQ9_w@mail.gmail.com>
On Mon, 8 Sep 2025 09:15:07 -0700 Mina Almasry wrote:
> > + /* Unconditionally set NOWARN if allocating from the datapath.
> > + * Use a single bit from the ATOMIC mask to help compiler optimize.
> > + */
> > + BUILD_BUG_ON(!(GFP_ATOMIC & __GFP_HIGH));
> > + if (gfp & __GFP_HIGH)
> > + gfp |= __GFP_NOWARN;
> > +
>
> I wonder if pp allocs are ever used for anything other than datapath
> pages (and if not, we can add __GPF_NOWARN here unconditionally. But
> this is good too I think.
datapath == in NAPI context, here. We still want the warning if
the allocations fail with GFP_KERNEL, e.g. during ndo_open.
next prev parent reply other threads:[~2025-09-08 20:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 15:21 [PATCH net-next] page_pool: always add GFP_NOWARN for ATOMIC allocations Jakub Kicinski
2025-09-08 16:15 ` Mina Almasry
2025-09-08 20:20 ` Jakub Kicinski [this message]
2025-09-11 0:52 ` Jakub Kicinski
2025-09-11 13:05 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250908132041.5ae74626@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=justinstitt@google.com \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).