From: Jakub Kicinski <kuba@kernel.org>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: dsahern@kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] udp_tunnel: use netdev_warn() instead of netdev_WARN()
Date: Mon, 8 Sep 2025 18:28:09 -0700 [thread overview]
Message-ID: <20250908182809.3e5a9fdf@kernel.org> (raw)
In-Reply-To: <20250905055927.2994625-1-alok.a.tiwari@oracle.com>
On Thu, 4 Sep 2025 22:59:22 -0700 Alok Tiwari wrote:
> netdev_WARN() uses WARN/WARN_ON to print a backtrace along with
> file and line information. In this case, udp_tunnel_nic_register()
> returning an error is just a failed operation, not a kernel bug.
This still lacks specificity. Take a look at the code and list
the code path which can ordinarily fail.
> A simple warning message is sufficient, so use netdev_warn()
> instead of netdev_WARN().
>
> The netdev_WARN use was a typo/misuse.
--
pw-bot: cr
prev parent reply other threads:[~2025-09-09 1:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 5:59 [PATCH v2 net-next] udp_tunnel: use netdev_warn() instead of netdev_WARN() Alok Tiwari
2025-09-05 13:08 ` Simon Horman
2025-09-09 1:28 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250908182809.3e5a9fdf@kernel.org \
--to=kuba@kernel.org \
--cc=alok.a.tiwari@oracle.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).