[PATCH v2 net-next] udp_tunnel: use netdev_warn() instead of netdev_WARN()

[PATCH v2 net-next] udp_tunnel: use netdev_warn() instead of netdev_WARN()

[Alok Tiwari]

netdev_WARN() uses WARN/WARN_ON to print a backtrace along with
file and line information. In this case, udp_tunnel_nic_register()
returning an error is just a failed operation, not a kernel bug.

A simple warning message is sufficient, so use netdev_warn()
instead of netdev_WARN().

The netdev_WARN use was a typo/misuse.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
v1 -> v2
Modified commit message as discuss with Simon.
https://lore.kernel.org/all/20250903195717.2614214-1-alok.a.tiwari@oracle.com/
---
 net/ipv4/udp_tunnel_nic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/udp_tunnel_nic.c b/net/ipv4/udp_tunnel_nic.c
index ff66db48453c..944b3cf25468 100644
--- a/net/ipv4/udp_tunnel_nic.c
+++ b/net/ipv4/udp_tunnel_nic.c
@@ -930,7 +930,7 @@ udp_tunnel_nic_netdevice_event(struct notifier_block *unused,
 
 		err = udp_tunnel_nic_register(dev);
 		if (err)
-			netdev_WARN(dev, "failed to register for UDP tunnel offloads: %d", err);
+			netdev_warn(dev, "failed to register for UDP tunnel offloads: %d", err);
 		return notifier_from_errno(err);
 	}
 	/* All other events will need the udp_tunnel_nic state */
-- 
2.50.1

Re: [PATCH v2 net-next] udp_tunnel: use netdev_warn() instead of netdev_WARN()

[Simon Horman]

On Thu, Sep 04, 2025 at 10:59:22PM -0700, Alok Tiwari wrote:
> netdev_WARN() uses WARN/WARN_ON to print a backtrace along with
> file and line information. In this case, udp_tunnel_nic_register()
> returning an error is just a failed operation, not a kernel bug.
> 
> A simple warning message is sufficient, so use netdev_warn()
> instead of netdev_WARN().
> 
> The netdev_WARN use was a typo/misuse.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
> v1 -> v2
> Modified commit message as discuss with Simon.
> https://lore.kernel.org/all/20250903195717.2614214-1-alok.a.tiwari@oracle.com/

Thanks for the update.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH v2 net-next] udp_tunnel: use netdev_warn() instead of netdev_WARN()

[Jakub Kicinski]

On Thu,  4 Sep 2025 22:59:22 -0700 Alok Tiwari wrote:
> netdev_WARN() uses WARN/WARN_ON to print a backtrace along with
> file and line information. In this case, udp_tunnel_nic_register()
> returning an error is just a failed operation, not a kernel bug.

This still lacks specificity. Take a look at the code and list
the code path which can ordinarily fail.

> A simple warning message is sufficient, so use netdev_warn()
> instead of netdev_WARN().
> 
> The netdev_WARN use was a typo/misuse.
-- 
pw-bot: cr