* [PATCH net] net/smc: Remove unused argument from 2 SMC functions
@ 2025-09-09 7:11 Mahanta Jambigi
2025-09-09 11:39 ` Dust Li
0 siblings, 1 reply; 6+ messages in thread
From: Mahanta Jambigi @ 2025-09-09 7:11 UTC (permalink / raw)
To: andrew+netdev, davem, edumazet, kuba, pabeni, alibuda, dust.li,
sidraya, wenjia
Cc: pasic, horms, tonylu, guwen, netdev, linux-s390, linux-rdma,
Mahanta Jambigi
The smc argument is not used in both smc_connect_ism_vlan_setup() &
smc_connect_ism_vlan_cleanup(). Hence removing it.
Fixes: 413498440e30 net/smc: add SMC-D support in af_smc
Signed-off-by: Mahanta Jambigi <mjambigi@linux.ibm.com>
Reviewed-by: Sidraya Jayagond <sidraya@linux.ibm.com>
---
net/smc/af_smc.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
index 66033afd168a..1ea54c09b3ac 100644
--- a/net/smc/af_smc.c
+++ b/net/smc/af_smc.c
@@ -1096,8 +1096,7 @@ static int smc_find_ism_v2_device_clnt(struct smc_sock *smc,
}
/* Check for VLAN ID and register it on ISM device just for CLC handshake */
-static int smc_connect_ism_vlan_setup(struct smc_sock *smc,
- struct smc_init_info *ini)
+static int smc_connect_ism_vlan_setup(struct smc_init_info *ini)
{
if (ini->vlan_id && smc_ism_get_vlan(ini->ism_dev[0], ini->vlan_id))
return SMC_CLC_DECL_ISMVLANERR;
@@ -1112,7 +1111,7 @@ static int smc_find_proposal_devices(struct smc_sock *smc,
/* check if there is an ism device available */
if (!(ini->smcd_version & SMC_V1) ||
smc_find_ism_device(smc, ini) ||
- smc_connect_ism_vlan_setup(smc, ini))
+ smc_connect_ism_vlan_setup(ini))
ini->smcd_version &= ~SMC_V1;
/* else ISM V1 is supported for this connection */
@@ -1157,8 +1156,7 @@ static int smc_find_proposal_devices(struct smc_sock *smc,
/* cleanup temporary VLAN ID registration used for CLC handshake. If ISM is
* used, the VLAN ID will be registered again during the connection setup.
*/
-static int smc_connect_ism_vlan_cleanup(struct smc_sock *smc,
- struct smc_init_info *ini)
+static int smc_connect_ism_vlan_cleanup(struct smc_init_info *ini)
{
if (!smcd_indicated(ini->smc_type_v1))
return 0;
@@ -1581,13 +1579,13 @@ static int __smc_connect(struct smc_sock *smc)
goto vlan_cleanup;
SMC_STAT_CLNT_SUCC_INC(sock_net(smc->clcsock->sk), aclc);
- smc_connect_ism_vlan_cleanup(smc, ini);
+ smc_connect_ism_vlan_cleanup(ini);
kfree(buf);
kfree(ini);
return 0;
vlan_cleanup:
- smc_connect_ism_vlan_cleanup(smc, ini);
+ smc_connect_ism_vlan_cleanup(ini);
kfree(buf);
fallback:
kfree(ini);
--
2.48.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net] net/smc: Remove unused argument from 2 SMC functions
2025-09-09 7:11 [PATCH net] net/smc: Remove unused argument from 2 SMC functions Mahanta Jambigi
@ 2025-09-09 11:39 ` Dust Li
2025-09-09 11:43 ` Mahanta Jambigi
0 siblings, 1 reply; 6+ messages in thread
From: Dust Li @ 2025-09-09 11:39 UTC (permalink / raw)
To: Mahanta Jambigi, andrew+netdev, davem, edumazet, kuba, pabeni,
alibuda, sidraya, wenjia
Cc: pasic, horms, tonylu, guwen, netdev, linux-s390, linux-rdma
On 2025-09-09 09:11:45, Mahanta Jambigi wrote:
>The smc argument is not used in both smc_connect_ism_vlan_setup() &
>smc_connect_ism_vlan_cleanup(). Hence removing it.
>
>Fixes: 413498440e30 net/smc: add SMC-D support in af_smc
The standard format for the Fixes tag requires the title to be enclosed
in parentheses.
But I don't think this is a bugfix.
>Signed-off-by: Mahanta Jambigi <mjambigi@linux.ibm.com>
>Reviewed-by: Sidraya Jayagond <sidraya@linux.ibm.com>
Besides,
Reviewed-by: Dust Li <dust.li@linux.alibaba.com>
Best regards,
Dust
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] net/smc: Remove unused argument from 2 SMC functions
2025-09-09 11:39 ` Dust Li
@ 2025-09-09 11:43 ` Mahanta Jambigi
2025-09-09 12:14 ` Dust Li
2025-09-09 12:36 ` Andrew Lunn
0 siblings, 2 replies; 6+ messages in thread
From: Mahanta Jambigi @ 2025-09-09 11:43 UTC (permalink / raw)
To: dust.li, andrew+netdev, davem, edumazet, kuba, pabeni, alibuda,
sidraya, wenjia
Cc: pasic, horms, tonylu, guwen, netdev, linux-s390, linux-rdma
On 09/09/25 5:09 pm, Dust Li wrote:
> On 2025-09-09 09:11:45, Mahanta Jambigi wrote:
>> The smc argument is not used in both smc_connect_ism_vlan_setup() &
>> smc_connect_ism_vlan_cleanup(). Hence removing it.
>>
>> Fixes: 413498440e30 net/smc: add SMC-D support in af_smc
>
> The standard format for the Fixes tag requires the title to be enclosed
> in parentheses.
I missed this. Let me fix it in next version.
>
> But I don't think this is a bugfix.
Yeah, its more of a clean up code. Should I use net-next? How should I
got about this.
>
>
>> Signed-off-by: Mahanta Jambigi <mjambigi@linux.ibm.com>
>> Reviewed-by: Sidraya Jayagond <sidraya@linux.ibm.com>
>
> Besides,
> Reviewed-by: Dust Li <dust.li@linux.alibaba.com>
>
> Best regards,
> Dust
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] net/smc: Remove unused argument from 2 SMC functions
2025-09-09 11:43 ` Mahanta Jambigi
@ 2025-09-09 12:14 ` Dust Li
2025-09-09 12:18 ` Mahanta Jambigi
2025-09-09 12:36 ` Andrew Lunn
1 sibling, 1 reply; 6+ messages in thread
From: Dust Li @ 2025-09-09 12:14 UTC (permalink / raw)
To: Mahanta Jambigi, andrew+netdev, davem, edumazet, kuba, pabeni,
alibuda, sidraya, wenjia
Cc: pasic, horms, tonylu, guwen, netdev, linux-s390, linux-rdma
On 2025-09-09 17:13:35, Mahanta Jambigi wrote:
>On 09/09/25 5:09 pm, Dust Li wrote:
>> On 2025-09-09 09:11:45, Mahanta Jambigi wrote:
>>> The smc argument is not used in both smc_connect_ism_vlan_setup() &
>>> smc_connect_ism_vlan_cleanup(). Hence removing it.
>>>
>>> Fixes: 413498440e30 net/smc: add SMC-D support in af_smc
>>
>> The standard format for the Fixes tag requires the title to be enclosed
>> in parentheses.
>
>I missed this. Let me fix it in next version.
>
>>
>> But I don't think this is a bugfix.
>
>Yeah, its more of a clean up code. Should I use net-next? How should I
>got about this.
Yes, I think it should remove the Fixes tag and go to net-next.
Best regards,
Dust
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] net/smc: Remove unused argument from 2 SMC functions
2025-09-09 12:14 ` Dust Li
@ 2025-09-09 12:18 ` Mahanta Jambigi
0 siblings, 0 replies; 6+ messages in thread
From: Mahanta Jambigi @ 2025-09-09 12:18 UTC (permalink / raw)
To: dust.li, andrew+netdev, davem, edumazet, kuba, pabeni, alibuda,
sidraya, wenjia
Cc: pasic, horms, tonylu, guwen, netdev, linux-s390, linux-rdma
On 09/09/25 5:44 pm, Dust Li wrote:
>
> Yes, I think it should remove the Fixes tag and go to net-next.
Sure. I'll do it in v2!
>
> Best regards,
> Dust
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] net/smc: Remove unused argument from 2 SMC functions
2025-09-09 11:43 ` Mahanta Jambigi
2025-09-09 12:14 ` Dust Li
@ 2025-09-09 12:36 ` Andrew Lunn
1 sibling, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2025-09-09 12:36 UTC (permalink / raw)
To: Mahanta Jambigi
Cc: dust.li, andrew+netdev, davem, edumazet, kuba, pabeni, alibuda,
sidraya, wenjia, pasic, horms, tonylu, guwen, netdev, linux-s390,
linux-rdma
> > But I don't think this is a bugfix.
>
> Yeah, its more of a clean up code. Should I use net-next? How should I
> got about this.
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
It must either fix a real bug that bothers people....
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-09-09 12:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-09 7:11 [PATCH net] net/smc: Remove unused argument from 2 SMC functions Mahanta Jambigi
2025-09-09 11:39 ` Dust Li
2025-09-09 11:43 ` Mahanta Jambigi
2025-09-09 12:14 ` Dust Li
2025-09-09 12:18 ` Mahanta Jambigi
2025-09-09 12:36 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).