From: Simon Horman <horms@kernel.org>
To: Yangyu Chen <cyy@cyyself.name>
Cc: netdev@vger.kernel.org, Igor Russkikh <irusskikh@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: atlantic: make RX page order tunable via module param
Date: Tue, 9 Sep 2025 10:13:13 +0100 [thread overview]
Message-ID: <20250909091313.GF2015@horms.kernel.org> (raw)
In-Reply-To: <tencent_E71C2F71D9631843941A5DF87204D1B5B509@qq.com>
On Sat, Sep 06, 2025 at 09:54:34PM +0800, Yangyu Chen wrote:
> On systems like AMD Strix Halo with Thunderbolt, RX map/unmap operations
> with IOMMU introduce significant performance overhead, making it difficult
> to achieve line rate with 10G NICs even with TCP over MTU 1500. Using
> higher order pages reduces this overhead, so this parameter is now
> configurable.
>
> After applying this patch and setting `rxpageorder=3`, testing with QNAP
> QNA-T310G1S on 10G Ethernet (MTU 1500) using `iperf3 -R` on IPv6 achieved
> 9.28Gbps compared to only 2.26Gbps previously.
VerU nice.
> Signed-off-by: Yangyu Chen <cyy@cyyself.name>
> ---
> Should we also consider make default AQ_CFG_RX_PAGEORDER to 3?
I have the same question.
...
> diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> index b24eaa5283fa..48f35fbf9a70 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> @@ -40,6 +40,10 @@ static unsigned int aq_itr_rx;
> module_param_named(aq_itr_rx, aq_itr_rx, uint, 0644);
> MODULE_PARM_DESC(aq_itr_rx, "RX interrupt throttle rate");
>
> +static unsigned int rxpageorder = AQ_CFG_RX_PAGEORDER;
> +module_param_named(rxpageorder, rxpageorder, uint, 0644);
> +MODULE_PARM_DESC(rxpageorder, "RX page order");
> +
Unfortunately adding new module parameters to networking drivers
is strongly discouraged. Can we find another way to address the problem
described in your cover: e.g.
1. Changing the fixed value
2. Somehow making the value auto detected
3. Some other mechanism to allow the user to configure the value, e.g. devlink
...
next prev parent reply other threads:[~2025-09-09 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-06 13:54 [PATCH] net: atlantic: make RX page order tunable via module param Yangyu Chen
2025-09-08 17:12 ` Andrew Lunn
2025-09-09 0:45 ` Jakub Kicinski
2025-09-09 9:13 ` Simon Horman [this message]
2025-09-09 9:15 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250909091313.GF2015@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cyy@cyyself.name \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=irusskikh@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).