From: Simon Horman <horms@kernel.org>
To: Yangyu Chen <cyy@cyyself.name>
Cc: netdev@vger.kernel.org, Igor Russkikh <irusskikh@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: atlantic: make RX page order tunable via module param
Date: Tue, 9 Sep 2025 10:15:50 +0100 [thread overview]
Message-ID: <20250909091550.GA13871@horms.kernel.org> (raw)
In-Reply-To: <20250909091313.GF2015@horms.kernel.org>
On Tue, Sep 09, 2025 at 10:13:17AM +0100, Simon Horman wrote:
> On Sat, Sep 06, 2025 at 09:54:34PM +0800, Yangyu Chen wrote:
...
> > diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> > index b24eaa5283fa..48f35fbf9a70 100644
> > --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> > +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> > @@ -40,6 +40,10 @@ static unsigned int aq_itr_rx;
> > module_param_named(aq_itr_rx, aq_itr_rx, uint, 0644);
> > MODULE_PARM_DESC(aq_itr_rx, "RX interrupt throttle rate");
> >
> > +static unsigned int rxpageorder = AQ_CFG_RX_PAGEORDER;
> > +module_param_named(rxpageorder, rxpageorder, uint, 0644);
> > +MODULE_PARM_DESC(rxpageorder, "RX page order");
> > +
>
> Unfortunately adding new module parameters to networking drivers
> is strongly discouraged. Can we find another way to address the problem
> described in your cover: e.g.
>
> 1. Changing the fixed value
> 2. Somehow making the value auto detected
> 3. Some other mechanism to allow the user to configure the value, e.g. devlink
>
> ...
Oops. I now see that Andrew and Jakub already responded.
And my comment doesn't add much. Sorry about that.
prev parent reply other threads:[~2025-09-09 9:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-06 13:54 [PATCH] net: atlantic: make RX page order tunable via module param Yangyu Chen
2025-09-08 17:12 ` Andrew Lunn
2025-09-09 0:45 ` Jakub Kicinski
2025-09-09 9:13 ` Simon Horman
2025-09-09 9:15 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250909091550.GA13871@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cyy@cyyself.name \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=irusskikh@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).