From: Leon Romanovsky <leon@kernel.org>
To: Tatyana Nikolova <tatyana.e.nikolova@intel.com>, jiri@resnulli.us
Cc: intel-wired-lan@lists.osuosl.org, przemyslaw.kitszel@intel.com,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
anthony.l.nguyen@intel.com
Subject: Re: [iwl-next] ice, irdma: Add rdma_qp_limits_sel devlink parameter for irdma
Date: Tue, 9 Sep 2025 15:20:51 +0300 [thread overview]
Message-ID: <20250909122051.GF341237@unreal> (raw)
In-Reply-To: <20250904195719.371-1-tatyana.e.nikolova@intel.com>
On Thu, Sep 04, 2025 at 02:57:19PM -0500, Tatyana Nikolova wrote:
> Add a devlink parameter to switch between different QP resource profiles
> (max number of QPs) supported by irdma for Intel Ethernet 800 devices. The
> rdma_qp_limits_sel is translated into an index in the rsrc_limits_table to
> select a power of two number between 1 and 256 for max supported QPs (1K-256K).
> To reduce the irdma memory footprint, set the rdma_qp_limits_sel default value
> to 1 (max 1K QPs).
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Tatyana Nikolova <tatyana.e.nikolova@intel.com>
> ---
> Since the changes to irdma are minor, this is targeted to iwl-next/net-next.
<...>
> #define DEVLINK_LOCAL_FWD_DISABLED_STR "disabled"
> #define DEVLINK_LOCAL_FWD_ENABLED_STR "enabled"
> #define DEVLINK_LOCAL_FWD_PRIORITIZED_STR "prioritized"
> @@ -1621,6 +1723,7 @@ enum ice_param_id {
> ICE_DEVLINK_PARAM_ID_BASE = DEVLINK_PARAM_GENERIC_ID_MAX,
> ICE_DEVLINK_PARAM_ID_TX_SCHED_LAYERS,
> ICE_DEVLINK_PARAM_ID_LOCAL_FWD,
> + ICE_DEVLINK_PARAM_ID_RDMA_QP_LIMITS_SEL,
> };
I was under impression that driver-specific devlink knobs are not
allowed. Was this limitation changed for Intel?
Thanks
next prev parent reply other threads:[~2025-09-09 13:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 19:57 [iwl-next] ice, irdma: Add rdma_qp_limits_sel devlink parameter for irdma Tatyana Nikolova
2025-09-09 12:20 ` Leon Romanovsky [this message]
2025-09-10 7:41 ` Przemek Kitszel
2025-09-10 12:13 ` Leon Romanovsky
2025-09-11 19:51 ` Przemek Kitszel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250909122051.GF341237@unreal \
--to=leon@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jiri@resnulli.us \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=tatyana.e.nikolova@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).