From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Jay Vosburgh <jv@jvosburgh.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCHv2 2/2] selftests: bonding: add vlan over bond testing
Date: Tue, 9 Sep 2025 19:26:06 -0700 [thread overview]
Message-ID: <20250909192606.6ac53aa4@kernel.org> (raw)
In-Reply-To: <aMDciKMGjr-_sW6E@fedora>
On Wed, 10 Sep 2025 02:03:52 +0000 Hangbin Liu wrote:
> On Tue, Sep 09, 2025 at 04:46:00PM -0700, Jakub Kicinski wrote:
> > On Mon, 8 Sep 2025 06:28:02 +0000 Hangbin Liu wrote:
> > > Add a vlan over bond testing to make sure arp/ns target works.
> > > Also change all the configs to mudules.
> >
> > Why are you switching everything to module?
> > The series needs to go to net, we should avoid unnecessary cleanups.
> > And I think changing the config is unrelated to the selftest so it
> > should be a standalone patch in the first place?
>
> On my local testing, there will be a lot default interfaces if all modules
> build in. This could make the test environment more clean.
> But it's just my preference.
No strong opinion on my side. Your point is fair. On the other hand
sometimes dealing with modules is tricky (especially with vng when
building kernel with O=build/). But not sure how much we should care
about shortcomings of tooling which can be fixed. It's okay for our CI.
> As you said, we can do it with a stand alone
> patch. I will re-post and drop the config update.
Yup! For net we should avoid it.
next prev parent reply other threads:[~2025-09-10 2:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 6:28 [PATCHv2 1/2] bonding: don't set oif to bond dev when getting NS target destination Hangbin Liu
2025-09-08 6:28 ` [PATCHv2 2/2] selftests: bonding: add vlan over bond testing Hangbin Liu
2025-09-09 23:46 ` Jakub Kicinski
2025-09-10 2:03 ` Hangbin Liu
2025-09-10 2:26 ` Jakub Kicinski [this message]
2025-09-08 15:55 ` [PATCHv2 1/2] bonding: don't set oif to bond dev when getting NS target destination David Wilder
2025-09-08 22:51 ` Jay Vosburgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250909192606.6ac53aa4@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jv@jvosburgh.net \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).