[PATCH net-next 1/2] selftests: Disable dad for ipv6 in fcnal-test.sh

[PATCH net-next 1/2] selftests: Disable dad for ipv6 in fcnal-test.sh

[David Ahern]

Constrained test environment; duplicate address detection is not needed
and causes races so disable it.

Signed-off-by: David Ahern <dsahern@kernel.org>
---
 tools/testing/selftests/net/fcnal-test.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh
index 69941520e8e5..068379a79651 100755
--- a/tools/testing/selftests/net/fcnal-test.sh
+++ b/tools/testing/selftests/net/fcnal-test.sh
@@ -424,6 +424,8 @@ create_ns()
 	ip netns exec ${ns} sysctl -qw net.ipv6.conf.all.keep_addr_on_down=1
 	ip netns exec ${ns} sysctl -qw net.ipv6.conf.all.forwarding=1
 	ip netns exec ${ns} sysctl -qw net.ipv6.conf.default.forwarding=1
+	ip netns exec ${ns} sysctl -qw net.ipv6.conf.default.accept_dad=0
+	ip netns exec ${ns} sysctl -qw net.ipv6.conf.all.accept_dad=0
 }
 
 # create veth pair to connect namespaces and apply addresses.
-- 
2.43.0

[PATCH net-next 2/2] selftests: Replace sleep with slowwait

[David Ahern]

Replace the sleep in kill_procs with slowwait.

Signed-off-by: David Ahern <dsahern@kernel.org>
---
 tools/testing/selftests/net/fcnal-test.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh
index 068379a79651..a527e3556763 100755
--- a/tools/testing/selftests/net/fcnal-test.sh
+++ b/tools/testing/selftests/net/fcnal-test.sh
@@ -189,7 +189,7 @@ show_hint()
 kill_procs()
 {
 	killall nettest ping ping6 >/dev/null 2>&1
-	sleep 1
+	slowwait 2 sh -c 'test -z "$(pgrep '"'^(nettest|ping|ping6)$'"')"'
 }
 
 set_ping_group()
-- 
2.43.0

Re: [PATCH net-next 1/2] selftests: Disable dad for ipv6 in fcnal-test.sh

[Simon Horman]

On Tue, Sep 09, 2025 at 08:58:27PM -0600, David Ahern wrote:
> Constrained test environment; duplicate address detection is not needed
> and causes races so disable it.
> 
> Signed-off-by: David Ahern <dsahern@kernel.org>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next 2/2] selftests: Replace sleep with slowwait

[Simon Horman]

On Tue, Sep 09, 2025 at 08:58:28PM -0600, David Ahern wrote:
> Replace the sleep in kill_procs with slowwait.
> 
> Signed-off-by: David Ahern <dsahern@kernel.org>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next 1/2] selftests: Disable dad for ipv6 in fcnal-test.sh

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  9 Sep 2025 20:58:27 -0600 you wrote:
> Constrained test environment; duplicate address detection is not needed
> and causes races so disable it.
> 
> Signed-off-by: David Ahern <dsahern@kernel.org>
> ---
>  tools/testing/selftests/net/fcnal-test.sh | 2 ++
>  1 file changed, 2 insertions(+)

Here is the summary with links:
  - [net-next,1/2] selftests: Disable dad for ipv6 in fcnal-test.sh
    https://git.kernel.org/netdev/net-next/c/53d591730ea3
  - [net-next,2/2] selftests: Replace sleep with slowwait
    https://git.kernel.org/netdev/net-next/c/2f186dd5585c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html