netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Eric Dumazet <edumazet@google.com>,
	linux-kernel@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
	Vinod Koul <vkoul@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	devicetree@vger.kernel.org, Jose Abreu <joabreu@synopsys.com>,
	netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	Conor Dooley <conor+dt@kernel.org>,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Richard Cochran <richardcochran@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/9] dt-bindings: net: qcom: document the ethqos device for SCMI-based systems
Date: Wed, 10 Sep 2025 09:36:18 -0500	[thread overview]
Message-ID: <20250910143618.GA4072335-robh@kernel.org> (raw)
In-Reply-To: <CAMRc=Mfom=QpqTrTSc_NEbKScOi1bLdVDO7kJ0+UQW9ydvdKjQ@mail.gmail.com>

On Wed, Sep 10, 2025 at 03:43:38PM +0200, Bartosz Golaszewski wrote:
> On Wed, Sep 10, 2025 at 3:38 PM Rob Herring (Arm) <robh@kernel.org> wrote:
> >
> >
> > On Wed, 10 Sep 2025 10:07:39 +0200, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> > > Describe the firmware-managed variant of the QCom DesignWare MAC. As the
> > > properties here differ a lot from the HLOS-managed variant, lets put it
> > > in a separate file.
> > >
> > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > ---
> > >  .../devicetree/bindings/net/qcom,ethqos-scmi.yaml  | 101 +++++++++++++++++++++
> > >  .../devicetree/bindings/net/snps,dwmac.yaml        |   4 +-
> > >  MAINTAINERS                                        |   1 +
> > >  3 files changed, 105 insertions(+), 1 deletion(-)
> > >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.example.dtb: ethernet@44000000 (renesas,r9a06g032-gmac): power-domains: [[4294967295]] is too short
> >         from schema $id: http://devicetree.org/schemas/net/renesas,rzn1-gmac.yaml#
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.example.dtb: ethernet@44000000 (renesas,r9a06g032-gmac): Unevaluated properties are not allowed ('clock-names', 'clocks', 'interrupt-names', 'interrupts', 'phy-mode', 'power-domains', 'reg', 'rx-fifo-depth', 'snps,multicast-filter-bins', 'snps,perfect-filter-entries', 'tx-fifo-depth' were unexpected)
> >         from schema $id: http://devicetree.org/schemas/net/renesas,rzn1-gmac.yaml#
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.example.dtb: ethernet@44000000 (renesas,r9a06g032-gmac): power-domains: [[4294967295]] is too short
> >         from schema $id: http://devicetree.org/schemas/net/snps,dwmac.yaml#
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000 (mediatek,mt2712-gmac): power-domains: [[4294967295, 4]] is too short
> >         from schema $id: http://devicetree.org/schemas/net/mediatek-dwmac.yaml#
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000 (mediatek,mt2712-gmac): Unevaluated properties are not allowed ('mac-address', 'phy-mode', 'reg', 'snps,reset-delays-us', 'snps,reset-gpio', 'snps,rxpbl', 'snps,txpbl' were unexpected)
> >         from schema $id: http://devicetree.org/schemas/net/mediatek-dwmac.yaml#
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000 (mediatek,mt2712-gmac): power-domains: [[4294967295, 4]] is too short
> >         from schema $id: http://devicetree.org/schemas/net/snps,dwmac.yaml#
> >
> 
> These seem to be a false-positives triggered by modifying the
> high-level snps.dwmac.yaml file?

No. You just made 3 power-domains required for everyone.

You have to test without DT_SCHEMA_FILES set so that every example is 
tested with every possible schema.

Rob

  reply	other threads:[~2025-09-10 14:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-10  8:07 [PATCH 0/9] net: stmmac: qcom-ethqos: add support for SCMI power domains Bartosz Golaszewski
2025-09-10  8:07 ` [PATCH 1/9] arm64: dts: qcom: sa8255: add ethernet nodes Bartosz Golaszewski
2025-09-10  8:07 ` [PATCH 2/9] dt-bindings: net: qcom: document the ethqos device for SCMI-based systems Bartosz Golaszewski
2025-09-10 13:38   ` Rob Herring (Arm)
2025-09-10 13:43     ` Bartosz Golaszewski
2025-09-10 14:36       ` Rob Herring [this message]
2025-09-10 14:42         ` Bartosz Golaszewski
2025-09-11  8:53           ` Konrad Dybcio
2025-09-11  9:22             ` Bartosz Golaszewski
2025-09-11  9:30               ` Konrad Dybcio
2025-09-10 16:04   ` Andrew Lunn
2025-09-11  8:58     ` Russell King (Oracle)
2025-09-10  8:07 ` [PATCH 3/9] net: stmmac: qcom-ethqos: use generic device properties Bartosz Golaszewski
2025-09-10  8:07 ` [PATCH 4/9] net: stmmac: qcom-ethqos: improve typing in devres callback Bartosz Golaszewski
2025-09-10  8:07 ` [PATCH 5/9] net: stmmac: qcom-ethqos: wrap emac driver data in additional structure Bartosz Golaszewski
2025-09-10  8:07 ` [PATCH 6/9] net: stmmac: qcom-ethqos: split power management fields into a separate structure Bartosz Golaszewski
2025-09-10  8:07 ` [PATCH 7/9] net: stmmac: qcom-ethqos: split power management context into a separate struct Bartosz Golaszewski
2025-09-10  8:07 ` [PATCH 8/9] net: stmmac: qcom-ethqos: define a callback for setting the serdes speed Bartosz Golaszewski
2025-09-10  8:07 ` [PATCH 9/9] net: stmmac: qcom-ethqos: add support for sa8255p Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250910143618.GA4072335-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andersson@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=joabreu@synopsys.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=peppe.cavallaro@st.com \
    --cc=richardcochran@gmail.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).