From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Mark Brown <broonie@kernel.org>,
Jonas Rebmann <jre@pengutronix.de>, Andrew Lunn <andrew@lunn.ch>,
imx@lists.linux.dev, linux-kernel@vger.kernel.org,
Eric Dumazet <edumazet@google.com>,
Fabio Estevam <festevam@gmail.com>, Rob Herring <robh@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
Shengjiu Wang <shengjiu.wang@nxp.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Vladimir Oltean <olteanv@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 1/4] dt-bindings: net: dsa: nxp,sja1105: Add reset-gpios property
Date: Wed, 10 Sep 2025 19:42:31 +0300 [thread overview]
Message-ID: <20250910164231.cnrexx4ds3cdg6lu@skbuf> (raw)
In-Reply-To: <20250910155359.tqole7726sapvgzr@pengutronix.de>
On Wed, Sep 10, 2025 at 05:53:59PM +0200, Marco Felsch wrote:
> IMHO silently removing the support will break designs for sure and
> should never be done. As said, imagine that the firmware will handle the
> supplies and the driver only needs to release the reset. If you silently
> remove the support, the device will be kept in reset-state. In field
> firmware updates are seldom, so you break your device by updating to a
> new kernel.
>
> One could argue that the driver supported it but there was no dt-binding
> yet, so it was a hidden/unstable feature but I don't know the policy.
Ok, I didn't think about, or meet, the case where Linux is required by
previous boot stages to deassert the reset. It is the first time you are
explicitly saying this, though.
So we can keep and document the 'reset-gpios' support, but we need to
explicitly point out that if present, it does not supplant the need to
ensure the proper POR sequence as per AH1704.
next prev parent reply other threads:[~2025-09-10 16:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 12:35 [PATCH 0/4] Mainline Protonic PRT8ML board Jonas Rebmann
2025-09-10 12:35 ` [PATCH 1/4] dt-bindings: net: dsa: nxp,sja1105: Add reset-gpios property Jonas Rebmann
2025-09-10 12:56 ` Vladimir Oltean
2025-09-10 14:30 ` Marco Felsch
2025-09-10 14:43 ` Vladimir Oltean
2025-09-10 15:09 ` Mark Brown
2025-09-10 15:34 ` Vladimir Oltean
2025-09-10 15:43 ` Mark Brown
2025-09-10 15:53 ` Marco Felsch
2025-09-10 16:42 ` Vladimir Oltean [this message]
2025-09-10 16:55 ` Marco Felsch
2025-09-15 0:08 ` Rob Herring
2025-09-10 12:35 ` [PATCH 2/4] ASoC: dt-bindings: asahi-kasei,ak4458: Reference common DAI properties Jonas Rebmann
2025-09-15 0:11 ` Rob Herring (Arm)
2025-09-10 12:35 ` [PATCH 3/4] dt-bindings: arm: fsl: Add Protonic PRT8ML Jonas Rebmann
2025-09-15 0:12 ` Rob Herring (Arm)
2025-09-10 12:35 ` [PATCH 4/4] arm64: dts: add Protonic PRT8ML board Jonas Rebmann
2025-09-16 21:41 ` (subset) [PATCH 0/4] Mainline " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250910164231.cnrexx4ds3cdg6lu@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jre@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox