From: Jakub Kicinski <kuba@kernel.org>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: "Marek Szyprowski" <m.szyprowski@samsung.com>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Hubert Wiśniewski" <hubert.wisniewski.25632@gmail.com>,
stable@vger.kernel.org, kernel@pengutronix.de,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"Lukas Wunner" <lukas@wunner.de>, "Xu Yang" <xu.yang_2@nxp.com>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH net v1 1/1] net: usb: asix: ax88772: drop phylink use in PM to avoid MDIO runtime PM wakeups
Date: Thu, 11 Sep 2025 07:55:13 -0700 [thread overview]
Message-ID: <20250911075513.1d90f8b0@kernel.org> (raw)
In-Reply-To: <aMLfGPIpWKwZszrY@shell.armlinux.org.uk>
On Thu, 11 Sep 2025 15:39:20 +0100 Russell King (Oracle) wrote:
> I'm not surprised. I'm guessing phylib is using polled mode, and
> removing the suspend/resume handling likely means that it's at the
> mercy of the timings of the phylib state machine running (which is
> what is complaining here) vs the MDIO bus being available for use.
>
> Given that this happens, I'm convinced that the original patch is
> the wrong approach. The driver needs the phylink suspend/resume
> calls to shutdown and restart phylib polling, and the resume call
> needs to be placed in such a location that the MDIO bus is already
> accessible.
We keep having issues with rtnl_lock taken from resume.
Honestly, I'm not sure anyone has found a good solution, yet.
Mostly people just don't implement runtime PM.
If we were able to pass optional context to suspend/resume
we could implement conditional locking. We'd lose a lot of
self-respect but it'd make fixing such bugs easier..
next prev parent reply other threads:[~2025-09-11 14:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250911135853eucas1p283b1afd37287b715403cd2cdbfa03a94@eucas1p2.samsung.com>
2025-09-08 11:26 ` [PATCH net v1 1/1] net: usb: asix: ax88772: drop phylink use in PM to avoid MDIO runtime PM wakeups Oleksij Rempel
2025-09-08 17:00 ` Hubert Wiśniewski
2025-09-09 7:17 ` Oleksij Rempel
2025-09-09 23:56 ` Jakub Kicinski
2025-09-10 4:16 ` Oleksij Rempel
2025-09-09 2:05 ` Xu Yang
2025-09-09 23:58 ` Jakub Kicinski
2025-09-10 4:11 ` Oleksij Rempel
2025-09-11 0:50 ` Jakub Kicinski
2025-09-11 1:00 ` patchwork-bot+netdevbpf
2025-09-11 13:58 ` Marek Szyprowski
2025-09-11 14:39 ` Russell King (Oracle)
2025-09-11 14:55 ` Jakub Kicinski [this message]
2025-09-11 20:46 ` Russell King (Oracle)
2025-09-12 2:30 ` Alan Stern
2025-09-12 8:33 ` Russell King (Oracle)
2025-09-12 14:29 ` Alan Stern
2025-09-12 14:37 ` Russell King (Oracle)
2025-09-13 6:45 ` Oleksij Rempel
2025-09-16 7:18 ` Oleksij Rempel
2025-09-16 14:42 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250911075513.1d90f8b0@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hubert.wisniewski.25632@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukas@wunner.de \
--cc=m.szyprowski@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).