[PATCH net] net: ethtool: handle EOPNOTSUPP from ethtool get_ts_info() method

[PATCH net] net: ethtool: handle EOPNOTSUPP from ethtool get_ts_info() method

[Russell King (Oracle)]

Network drivers sometimes return -EOPNOTSUPP from their get_ts_info()
method, and this should not cause the reporting of PHY timestamping
information to be prohibited. Handle this error code, and also
arrange for ethtool_net_get_ts_info_by_phc() to return -EOPNOTSUPP
when the method is not implemented.

This allows e.g. PHYs connected to DSA switches which support
timestamping to report their timestamping capabilities.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
 net/ethtool/common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/ethtool/common.c b/net/ethtool/common.c
index 4f58648a27ad..92e6a681c797 100644
--- a/net/ethtool/common.c
+++ b/net/ethtool/common.c
@@ -905,7 +905,7 @@ int ethtool_net_get_ts_info_by_phc(struct net_device *dev,
 	int err;
 
 	if (!ops->get_ts_info)
-		return -ENODEV;
+		return -EOPNOTSUPP;
 
 	/* Does ptp comes from netdev */
 	ethtool_init_tsinfo(info);
@@ -973,7 +973,7 @@ int ethtool_get_ts_info_by_phc(struct net_device *dev,
 	int err;
 
 	err = ethtool_net_get_ts_info_by_phc(dev, info, hwprov_desc);
-	if (err == -ENODEV) {
+	if (err == -ENODEV || err == -EOPNOTSUPP) {
 		struct phy_device *phy;
 
 		phy = ethtool_phy_get_ts_info_by_phc(dev, info, hwprov_desc);
-- 
2.47.3

Re: [PATCH net] net: ethtool: handle EOPNOTSUPP from ethtool get_ts_info() method

[Simon Horman]

On Tue, Sep 09, 2025 at 03:07:17PM +0100, Russell King (Oracle) wrote:
> Network drivers sometimes return -EOPNOTSUPP from their get_ts_info()
> method, and this should not cause the reporting of PHY timestamping
> information to be prohibited. Handle this error code, and also
> arrange for ethtool_net_get_ts_info_by_phc() to return -EOPNOTSUPP
> when the method is not implemented.
> 
> This allows e.g. PHYs connected to DSA switches which support
> timestamping to report their timestamping capabilities.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Reviewed-by: Simon Horman <horms@kernel.org>

[PATCH net] net: ethtool: handle EOPNOTSUPP from ethtool get_ts_info() method

[Russell King (Oracle)]

Network drivers sometimes return -EOPNOTSUPP from their get_ts_info()
method, and this should not cause the reporting of PHY timestamping
information to be prohibited. Handle this error code, and also
arrange for ethtool_net_get_ts_info_by_phc() to return -EOPNOTSUPP
when the method is not implemented.

This allows e.g. PHYs connected to DSA switches which support
timestamping to report their timestamping capabilities.

Fixes: b9e3f7dc9ed9 ("net: ethtool: tsinfo: Enhance tsinfo to support several hwtstamp by net topology")
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
--
v2: add Fixes: tag
---
 net/ethtool/common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/ethtool/common.c b/net/ethtool/common.c
index 4f58648a27ad..92e6a681c797 100644
--- a/net/ethtool/common.c
+++ b/net/ethtool/common.c
@@ -905,7 +905,7 @@ int ethtool_net_get_ts_info_by_phc(struct net_device *dev,
 	int err;
 
 	if (!ops->get_ts_info)
-		return -ENODEV;
+		return -EOPNOTSUPP;
 
 	/* Does ptp comes from netdev */
 	ethtool_init_tsinfo(info);
@@ -973,7 +973,7 @@ int ethtool_get_ts_info_by_phc(struct net_device *dev,
 	int err;
 
 	err = ethtool_net_get_ts_info_by_phc(dev, info, hwprov_desc);
-	if (err == -ENODEV) {
+	if (err == -ENODEV || err == -EOPNOTSUPP) {
 		struct phy_device *phy;
 
 		phy = ethtool_phy_get_ts_info_by_phc(dev, info, hwprov_desc);
-- 
2.47.3

Re: [PATCH net] net: ethtool: handle EOPNOTSUPP from ethtool get_ts_info() method

[Kory Maincent]

On Thu, 11 Sep 2025 15:43:15 +0100
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk> wrote:

> Network drivers sometimes return -EOPNOTSUPP from their get_ts_info()
> method, and this should not cause the reporting of PHY timestamping
> information to be prohibited. Handle this error code, and also
> arrange for ethtool_net_get_ts_info_by_phc() to return -EOPNOTSUPP
> when the method is not implemented.
> 
> This allows e.g. PHYs connected to DSA switches which support
> timestamping to report their timestamping capabilities.

You forgot the v2 in the subject prefix.

Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>

Thank you!
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Re: [PATCH net] net: ethtool: handle EOPNOTSUPP from ethtool get_ts_info() method

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 11 Sep 2025 15:43:15 +0100 you wrote:
> Network drivers sometimes return -EOPNOTSUPP from their get_ts_info()
> method, and this should not cause the reporting of PHY timestamping
> information to be prohibited. Handle this error code, and also
> arrange for ethtool_net_get_ts_info_by_phc() to return -EOPNOTSUPP
> when the method is not implemented.
> 
> This allows e.g. PHYs connected to DSA switches which support
> timestamping to report their timestamping capabilities.
> 
> [...]

Here is the summary with links:
  - [net] net: ethtool: handle EOPNOTSUPP from ethtool get_ts_info() method
    https://git.kernel.org/netdev/net/c/201825fb4278

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html