* [PATCH] selftests/Makefile: include $(INSTALL_DEP_TARGETS) in clean target to clean net/lib dependency
@ 2025-09-10 11:30 Nai-Chen Cheng
2025-09-11 17:27 ` Simon Horman
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Nai-Chen Cheng @ 2025-09-10 11:30 UTC (permalink / raw)
To: Shuah Khan, Jakub Kicinski, Paolo Abeni, David S. Miller,
Eric Dumazet, Simon Horman
Cc: netdev, linux-kselftest, linux-kernel, linux-kernel-mentees,
Nai-Chen Cheng
The selftests 'make clean' does not clean the net/lib because it only
processes $(TARGETS) and ignores $(INSTALL_DEP_TARGETS). This leaves
compiled objects in net/lib after cleaning, requiring manual cleanup.
Include $(INSTALL_DEP_TARGETS) in clean target to ensure net/lib
dependency is properly cleaned.
Signed-off-by: Nai-Chen Cheng <bleach1827@gmail.com>
---
tools/testing/selftests/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 030da61dbff3a7e4a22d61ba3972e248a43d374d..a2d8e1093b005c9af3570246dd8b10b59e44b46b 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -314,7 +314,7 @@ gen_tar: install
@echo "Created ${TAR_PATH}"
clean:
- @for TARGET in $(TARGETS); do \
+ @for TARGET in $(TARGETS) $(INSTALL_DEP_TARGETS); do \
BUILD_TARGET=$$BUILD/$$TARGET; \
$(MAKE) OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\
done;
---
base-commit: 9dd1835ecda5b96ac88c166f4a87386f3e727bd9
change-id: 20250910-selftests-makefile-clean-cc2fb70e9e32
Best regards,
--
Nai-Chen Cheng <bleach1827@gmail.com>
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] selftests/Makefile: include $(INSTALL_DEP_TARGETS) in clean target to clean net/lib dependency
2025-09-10 11:30 [PATCH] selftests/Makefile: include $(INSTALL_DEP_TARGETS) in clean target to clean net/lib dependency Nai-Chen Cheng
@ 2025-09-11 17:27 ` Simon Horman
2025-09-11 23:41 ` Jakub Kicinski
2025-09-16 23:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2025-09-11 17:27 UTC (permalink / raw)
To: Nai-Chen Cheng
Cc: Shuah Khan, Jakub Kicinski, Paolo Abeni, David S. Miller,
Eric Dumazet, netdev, linux-kselftest, linux-kernel,
linux-kernel-mentees
On Wed, Sep 10, 2025 at 07:30:32PM +0800, Nai-Chen Cheng wrote:
> The selftests 'make clean' does not clean the net/lib because it only
> processes $(TARGETS) and ignores $(INSTALL_DEP_TARGETS). This leaves
> compiled objects in net/lib after cleaning, requiring manual cleanup.
>
> Include $(INSTALL_DEP_TARGETS) in clean target to ensure net/lib
> dependency is properly cleaned.
>
> Signed-off-by: Nai-Chen Cheng <bleach1827@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Simon Horman <horms@kernel.org> # build-tested
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/Makefile: include $(INSTALL_DEP_TARGETS) in clean target to clean net/lib dependency
2025-09-10 11:30 [PATCH] selftests/Makefile: include $(INSTALL_DEP_TARGETS) in clean target to clean net/lib dependency Nai-Chen Cheng
2025-09-11 17:27 ` Simon Horman
@ 2025-09-11 23:41 ` Jakub Kicinski
2025-09-16 22:59 ` Shuah Khan
2025-09-16 23:10 ` patchwork-bot+netdevbpf
2 siblings, 1 reply; 5+ messages in thread
From: Jakub Kicinski @ 2025-09-11 23:41 UTC (permalink / raw)
To: Nai-Chen Cheng
Cc: Shuah Khan, Paolo Abeni, David S. Miller, Eric Dumazet,
Simon Horman, netdev, linux-kselftest, linux-kernel,
linux-kernel-mentees
On Wed, 10 Sep 2025 19:30:32 +0800 Nai-Chen Cheng wrote:
> The selftests 'make clean' does not clean the net/lib because it only
> processes $(TARGETS) and ignores $(INSTALL_DEP_TARGETS). This leaves
> compiled objects in net/lib after cleaning, requiring manual cleanup.
>
> Include $(INSTALL_DEP_TARGETS) in clean target to ensure net/lib
> dependency is properly cleaned.
Shuah, please LMK if think it makes sense for netdev to take this
(net/lib is the only DEP_TARGET today).
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/Makefile: include $(INSTALL_DEP_TARGETS) in clean target to clean net/lib dependency
2025-09-11 23:41 ` Jakub Kicinski
@ 2025-09-16 22:59 ` Shuah Khan
0 siblings, 0 replies; 5+ messages in thread
From: Shuah Khan @ 2025-09-16 22:59 UTC (permalink / raw)
To: Jakub Kicinski, Nai-Chen Cheng
Cc: Shuah Khan, Paolo Abeni, David S. Miller, Eric Dumazet,
Simon Horman, netdev, linux-kselftest, linux-kernel,
linux-kernel-mentees, Shuah Khan
On 9/11/25 17:41, Jakub Kicinski wrote:
> On Wed, 10 Sep 2025 19:30:32 +0800 Nai-Chen Cheng wrote:
>> The selftests 'make clean' does not clean the net/lib because it only
>> processes $(TARGETS) and ignores $(INSTALL_DEP_TARGETS). This leaves
>> compiled objects in net/lib after cleaning, requiring manual cleanup.
>>
>> Include $(INSTALL_DEP_TARGETS) in clean target to ensure net/lib
>> dependency is properly cleaned.
>
> Shuah, please LMK if think it makes sense for netdev to take this
> (net/lib is the only DEP_TARGET today).
No problems - take this through netdev
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/Makefile: include $(INSTALL_DEP_TARGETS) in clean target to clean net/lib dependency
2025-09-10 11:30 [PATCH] selftests/Makefile: include $(INSTALL_DEP_TARGETS) in clean target to clean net/lib dependency Nai-Chen Cheng
2025-09-11 17:27 ` Simon Horman
2025-09-11 23:41 ` Jakub Kicinski
@ 2025-09-16 23:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-09-16 23:10 UTC (permalink / raw)
To: Nai-Chen Cheng
Cc: shuah, kuba, pabeni, davem, edumazet, horms, netdev,
linux-kselftest, linux-kernel, linux-kernel-mentees
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 10 Sep 2025 19:30:32 +0800 you wrote:
> The selftests 'make clean' does not clean the net/lib because it only
> processes $(TARGETS) and ignores $(INSTALL_DEP_TARGETS). This leaves
> compiled objects in net/lib after cleaning, requiring manual cleanup.
>
> Include $(INSTALL_DEP_TARGETS) in clean target to ensure net/lib
> dependency is properly cleaned.
>
> [...]
Here is the summary with links:
- selftests/Makefile: include $(INSTALL_DEP_TARGETS) in clean target to clean net/lib dependency
https://git.kernel.org/netdev/net-next/c/d3f7457da7b9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-09-16 23:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-10 11:30 [PATCH] selftests/Makefile: include $(INSTALL_DEP_TARGETS) in clean target to clean net/lib dependency Nai-Chen Cheng
2025-09-11 17:27 ` Simon Horman
2025-09-11 23:41 ` Jakub Kicinski
2025-09-16 22:59 ` Shuah Khan
2025-09-16 23:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).