Re: [PATCH net-next 3/4] net/mlx5: Add net namespace support to devcom

[Simon Horman <horms@kernel.org>]

On Thu, Sep 11, 2025 at 09:31:06AM +0300, Tariq Toukan wrote:
> From: Shay Drory <shayd@nvidia.com>
> 
> Extend the devcom framework to support namespace-aware components.
> 
> The existing devcom matching logic was based solely on numeric keys,
> limiting its use to the global (init_net) scope or requiring clients
> to ignore namespaces altogether, both of which are incorrect in
> multi-namespace environments.
> 
> This patch introduces namespace support by allowing devcom clients to
> provide a namespace match attribute. The devcom pairing mechanism is
> updated to compare the namespace, enabling proper isolation and
> interaction of components across different net namespaces.
> 
> With this change, components that require namespace aware pairing,
> such as SD groups or LAG, can now work correctly in multi-namespace
> scenarios. In particular, this opens the way to support hardware LAG
> within a net namespace.
> 
> Signed-off-by: Shay Drory <shayd@nvidia.com>
> Reviewed-by: Mark Bloch <mbloch@nvidia.com>
> Reviewed-by: Parav Pandit <parav@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

I've reviewed this with the assumptions that; mlx5_core_net() returns the
devlink net namespace, and; that the devlink net namespace is fixed.

With those assumptions, this looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>