[PATCH net-next v2 0/2] net: phy: print warning if usage of deprecated array-style fixed-link binding is detected

[PATCH net-next v2 0/2] net: phy: print warning if usage of deprecated array-style fixed-link binding is detected

[Heiner Kallweit]

The array-style fixed-link binding has been marked deprecated for more
than 10 yrs, but still there's a number of users. Print a warning when
usage of the deprecated binding is detected.

v2:
- use dedicated printk specifiers

Heiner Kallweit (2):
  of: mdio: warn if deprecated fixed-link binding is used
  net: phylink: warn if deprecated array-style fixed-link binding is
    used

 drivers/net/mdio/of_mdio.c | 2 ++
 drivers/net/phy/phylink.c  | 3 +++
 2 files changed, 5 insertions(+)

-- 
2.51.0

[PATCH net-next v2 1/2] of: mdio: warn if deprecated fixed-link binding is used

[Heiner Kallweit]

The array-style fixed-link binding has been marked deprecated for more
than 10 yrs, but still there's a number of users. Print a warning when
usage of the deprecated binding is detected.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
v2:
- use %pOF printk specifier
---
 drivers/net/mdio/of_mdio.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c
index d8ca63ed8..24e03f7a6 100644
--- a/drivers/net/mdio/of_mdio.c
+++ b/drivers/net/mdio/of_mdio.c
@@ -447,6 +447,8 @@ int of_phy_register_fixed_link(struct device_node *np)
 	/* Old binding */
 	if (of_property_read_u32_array(np, "fixed-link", fixed_link_prop,
 				       ARRAY_SIZE(fixed_link_prop)) == 0) {
+		pr_warn_once("%pOF uses deprecated array-style fixed-link binding!",
+			     np);
 		status.link = 1;
 		status.duplex = fixed_link_prop[1];
 		status.speed  = fixed_link_prop[2];
-- 
2.51.0

[PATCH net-next v2 2/2] net: phylink: warn if deprecated array-style fixed-link binding is used

[Heiner Kallweit]

The array-style fixed-link binding has been marked deprecated for more
than 10 yrs, but still there's a number of users. Print a warning when
usage of the deprecated binding is detected.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
v2:
- use %pfw printk specifier
---
 drivers/net/phy/phylink.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index 1988b7d20..0524dcc1b 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -702,6 +702,9 @@ static int phylink_parse_fixedlink(struct phylink *pl,
 			return -EINVAL;
 		}
 
+		phylink_warn(pl, "%pfw uses deprecated array-style fixed-link binding!",
+			     fwnode);
+
 		ret = fwnode_property_read_u32_array(fwnode, "fixed-link",
 						     prop, ARRAY_SIZE(prop));
 		if (!ret) {
-- 
2.51.0

Re: [PATCH net-next v2 2/2] net: phylink: warn if deprecated array-style fixed-link binding is used

[Russell King (Oracle)]

On Thu, Sep 11, 2025 at 09:20:48PM +0200, Heiner Kallweit wrote:
> The array-style fixed-link binding has been marked deprecated for more
> than 10 yrs, but still there's a number of users. Print a warning when
> usage of the deprecated binding is detected.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v2:
> - use %pfw printk specifier
> ---
>  drivers/net/phy/phylink.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index 1988b7d20..0524dcc1b 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -702,6 +702,9 @@ static int phylink_parse_fixedlink(struct phylink *pl,
>  			return -EINVAL;
>  		}
>  
> +		phylink_warn(pl, "%pfw uses deprecated array-style fixed-link binding!",

\n at the end of a kernel message string is normal.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

Re: [PATCH net-next v2 1/2] of: mdio: warn if deprecated fixed-link binding is used

[Russell King (Oracle)]

On Thu, Sep 11, 2025 at 09:19:26PM +0200, Heiner Kallweit wrote:
> The array-style fixed-link binding has been marked deprecated for more
> than 10 yrs, but still there's a number of users. Print a warning when
> usage of the deprecated binding is detected.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v2:
> - use %pOF printk specifier
> ---
>  drivers/net/mdio/of_mdio.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c
> index d8ca63ed8..24e03f7a6 100644
> --- a/drivers/net/mdio/of_mdio.c
> +++ b/drivers/net/mdio/of_mdio.c
> @@ -447,6 +447,8 @@ int of_phy_register_fixed_link(struct device_node *np)
>  	/* Old binding */
>  	if (of_property_read_u32_array(np, "fixed-link", fixed_link_prop,
>  				       ARRAY_SIZE(fixed_link_prop)) == 0) {
> +		pr_warn_once("%pOF uses deprecated array-style fixed-link binding!",

Ditto.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

Re: [PATCH net-next v2 0/2] net: phy: print warning if usage of deprecated array-style fixed-link binding is detected

[Heiner Kallweit]

On 9/11/2025 9:18 PM, Heiner Kallweit wrote:
> The array-style fixed-link binding has been marked deprecated for more
> than 10 yrs, but still there's a number of users. Print a warning when
> usage of the deprecated binding is detected.
> 
> v2:
> - use dedicated printk specifiers
> 
> Heiner Kallweit (2):
>   of: mdio: warn if deprecated fixed-link binding is used
>   net: phylink: warn if deprecated array-style fixed-link binding is
>     used
> 
>  drivers/net/mdio/of_mdio.c | 2 ++
>  drivers/net/phy/phylink.c  | 3 +++
>  2 files changed, 5 insertions(+)
> 
--
pw-bot: cr

Re: [PATCH net-next v2 0/2] net: phy: print warning if usage of deprecated array-style fixed-link binding is detected

[Jakub Kicinski]

On Fri, 12 Sep 2025 07:31:19 +0200 Heiner Kallweit wrote:
> On 9/11/2025 9:18 PM, Heiner Kallweit wrote:
> > The array-style fixed-link binding has been marked deprecated for more
> > than 10 yrs, but still there's a number of users. Print a warning when
> > usage of the deprecated binding is detected.
> > 
> > v2:
> > - use dedicated printk specifiers
> > 
> > Heiner Kallweit (2):
> >   of: mdio: warn if deprecated fixed-link binding is used
> >   net: phylink: warn if deprecated array-style fixed-link binding is
> >     used
> > 
> >  drivers/net/mdio/of_mdio.c | 2 ++
> >  drivers/net/phy/phylink.c  | 3 +++
> >  2 files changed, 5 insertions(+)
> >   
> --
> pw-bot: cr

This was already discarded from PW by the time you send this. 
Please note:

Quoting documentation:

  Updating patch status
  ~~~~~~~~~~~~~~~~~~~~~
  [...] 
  The use of the bot is entirely optional, if in doubt ignore its existence
  completely. Maintainers will classify and update the state of the patches
  themselves. No email should ever be sent to the list with the main purpose
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  of communicating with the bot, the bot commands should be seen as metadata.
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  [...]
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#updating-patch-status