From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85CA911185; Sat, 13 Sep 2025 00:27:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757723263; cv=none; b=L7LQQ8Ac22s1yFdJBrm7ggUNT1ylsYQ+3mdw67qoNSu6aulX1Z1weWe1tZQuQ4hiF8kdxgurcDXSG9ly98hHkWP1FgE/9jii/ubmnT1pEmM3GRomjMhxajdxQM7+hMwp9Du63QWQkGnV+AvCJNFaxM80FMpyYdrGBWfK4Az3Sns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757723263; c=relaxed/simple; bh=HrdxcHyCtTTpJcAiGydPfegXvya3mJ/jU4zuZbNMC1c=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ltI0qevkIS2b+gnhiiMbwbz+sL9/JdAlQLSQ5RzXM285wJH53k7hp/Woxw777THZ06nXYMVKx1Rqj9/jFA/rzUMkfi6u+LQvy442jyOCLrSVqU8SLEAlsItusMcXTlq4h9nsvhqTHm+bE1T2ZtTWxlb6IKIOtdLWU5+n2yMUun8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jl8r/DQa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jl8r/DQa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7CCDC4CEF1; Sat, 13 Sep 2025 00:27:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757723263; bh=HrdxcHyCtTTpJcAiGydPfegXvya3mJ/jU4zuZbNMC1c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jl8r/DQaPWLqwN59Ues0LAqaFmw1BsYEWwk6QoB/JaWfdLS0H1jTp347z+nrvefOK 6A8BuEy/INlx4poANaVVGdXnEcvBvERS/HS0V94TY/ozx+6snBsFFhV3tAp7X1WQp5 oS8B5X8c26FdRzOzpS7T9I2GxsHmZ7iN+/AjzjYVrYstLLy2eYQlCnU6etIqMzcGNg 3N8Ie/7RZQ2XgF3eJsvemrnL6Lwd9LTi/CcB7qPOLMLHadZNPViaGUit0tdSbYyO49 5BD+9o2M2D4sKptHi7c7NCZqYoeJOoR2jQlt9IiOJqKpc8ewoVabq4oFnzL3qw/HRD t0Gov+OCRR/+A== Date: Fri, 12 Sep 2025 17:27:42 -0700 From: Jakub Kicinski To: =?UTF-8?B?QXNiasO4cm4=?= Sloth =?UTF-8?B?VMO4bm5lc2Vu?= Cc: "Jason A. Donenfeld" , "David S. Miller" , Eric Dumazet , Paolo Abeni , Donald Hunter , Simon Horman , Jacob Keller , Sabrina Dubroca , wireguard@lists.zx2c4.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 08/13] tools: ynl-gen: only validate nested array payload Message-ID: <20250912172742.3a41b81e@kernel.org> In-Reply-To: <20250911200508.79341-9-ast@fiberby.net> References: <20250911200508.79341-1-ast@fiberby.net> <20250911200508.79341-9-ast@fiberby.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 11 Sep 2025 20:05:01 +0000 Asbj=C3=B8rn Sloth T=C3=B8nnesen wrote: > +int ynl_attr_validate_payload(struct ynl_parse_arg *yarg, > + const struct nlattr *attr, unsigned int type) > +{ > + return __ynl_attr_validate(yarg, attr, type); > +} Why not expose __ynl_attr_validate() to the callers? I don't think the _payload() suffix is crystal clear, we're still validating attr, _payload() makes it sound like we're validating what's inside attr?