From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux.dev, "Lei Yang" <leiyang@redhat.com>,
kernel-team@meta.com
Subject: Re: [PATCH net-next v2 4/7] net: ethtool: add get_rx_ring_count callback to optimize RX ring queries
Date: Sun, 14 Sep 2025 12:59:49 -0700 [thread overview]
Message-ID: <20250914125949.17ea0ade@kernel.org> (raw)
In-Reply-To: <20250912-gxrings-v2-4-3c7a60bbeebf@debian.org>
On Fri, 12 Sep 2025 08:59:13 -0700 Breno Leitao wrote:
> @@ -1225,9 +1242,7 @@ static noinline_for_stack int ethtool_get_rxrings(struct net_device *dev,
> if (ret)
> return ret;
>
> - ret = ops->get_rxnfc(dev, &info, NULL);
> - if (ret < 0)
> - return ret;
> + info.data = ethtool_get_rx_ring_count(dev);
Is there a reason we're no longer checking for negative errno here?
It's possible that none of the drivers actually return an error, but
we should still check. For consistency with the other patches / paths
if nothing else.
> return ethtool_rxnfc_copy_to_user(useraddr, &info, info_size, NULL);
--
pw-bot: cr
next prev parent reply other threads:[~2025-09-14 19:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 15:59 [PATCH net-next v2 0/7] net: ethtool: add dedicated GRXRINGS driver callbacks Breno Leitao
2025-09-12 15:59 ` [PATCH net-next v2 1/7] net: ethtool: pass the num of RX rings directly to ethtool_copy_validate_indir Breno Leitao
2025-09-12 15:59 ` [PATCH net-next v2 2/7] net: ethtool: add support for ETHTOOL_GRXRINGS ioctl Breno Leitao
2025-09-12 15:59 ` [PATCH net-next v2 3/7] net: ethtool: remove the duplicated handling from ethtool_get_rxrings Breno Leitao
2025-09-12 15:59 ` [PATCH net-next v2 4/7] net: ethtool: add get_rx_ring_count callback to optimize RX ring queries Breno Leitao
2025-09-14 19:59 ` Jakub Kicinski [this message]
2025-09-15 9:12 ` Breno Leitao
2025-09-12 15:59 ` [PATCH net-next v2 5/7] net: ethtool: update set_rxfh to use ethtool_get_rx_ring_count helper Breno Leitao
2025-09-12 15:59 ` [PATCH net-next v2 6/7] net: ethtool: update set_rxfh_indir " Breno Leitao
2025-09-12 15:59 ` [PATCH net-next v2 7/7] net: virtio_net: add get_rxrings ethtool callback for RX ring queries Breno Leitao
2025-09-15 10:50 ` [PATCH net-next v2 0/7] net: ethtool: add dedicated GRXRINGS driver callbacks Lei Yang
2025-09-15 10:55 ` Breno Leitao
2025-09-15 10:57 ` Breno Leitao
2025-09-15 14:45 ` Lei Yang
2025-09-15 15:22 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250914125949.17ea0ade@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=horms@kernel.org \
--cc=jasowang@redhat.com \
--cc=kernel-team@meta.com \
--cc=leitao@debian.org \
--cc=leiyang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).