From: Jakub Kicinski <kuba@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Donald Hunter <donald.hunter@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Kory Maincent <kory.maincent@bootlin.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Nishanth Menon <nm@ti.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, UNGLinuxDriver@microchip.com,
linux-doc@vger.kernel.org, Michal Kubecek <mkubecek@suse.cz>,
Roan van Dijk <roan@protonic.nl>
Subject: Re: [PATCH net-next v5 2/5] ethtool: netlink: add ETHTOOL_MSG_MSE_GET and wire up PHY MSE access
Date: Mon, 15 Sep 2025 08:07:20 -0700 [thread overview]
Message-ID: <20250915080720.17646515@kernel.org> (raw)
In-Reply-To: <aMfczCuRf0bm2GgQ@pengutronix.de>
On Mon, 15 Sep 2025 11:30:52 +0200 Oleksij Rempel wrote:
> On Fri, Sep 12, 2025 at 05:00:53PM -0700, Jakub Kicinski wrote:
> > On Fri, 12 Sep 2025 12:07:42 +0200 Oleksij Rempel wrote:
> > > I would prefer to keep u64 for refresh-rate-ps and num-symbols.
> > >
> > > My reasoning comes from comparing the design decisions of today's industrial
> > > hardware to the projected needs of upcoming standards like 800 Gbit/s. This
> > > analysis shows that future PHYs will require values that exceed the limits of a
> > > u32.
> >
> > but u64 may or may not also have some alignment expectations, which uint
> > explicitly excludes
>
> just to confirm - if we declare an attribute as type: uint in the YAML
> spec, the kernel side can still use nla_put_u64() to send a 64-bit
> value, correct? My understanding is that uint is a flexible integer
> type, so userspace decoders will accept both 4-byte and 8-byte encodings
> transparently.
Theoretically, and yes. But why would you use put_u64 and not
put_uint() ?
next prev parent reply other threads:[~2025-09-15 15:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 12:46 [PATCH net-next v5 0/5] ethtool: introduce PHY MSE diagnostics UAPI and drivers Oleksij Rempel
2025-09-08 12:46 ` [PATCH net-next v5 1/5] ethtool: introduce core UAPI and driver API for PHY MSE diagnostics Oleksij Rempel
2025-09-12 2:23 ` Jakub Kicinski
2025-09-12 10:21 ` Oleksij Rempel
2025-09-12 23:54 ` Jakub Kicinski
2025-09-08 12:46 ` [PATCH net-next v5 2/5] ethtool: netlink: add ETHTOOL_MSG_MSE_GET and wire up PHY MSE access Oleksij Rempel
2025-09-12 2:34 ` Jakub Kicinski
2025-09-12 10:07 ` Oleksij Rempel
2025-09-13 0:00 ` Jakub Kicinski
2025-09-15 9:30 ` Oleksij Rempel
2025-09-15 15:07 ` Jakub Kicinski [this message]
2025-09-16 4:56 ` Oleksij Rempel
2025-09-08 12:46 ` [PATCH net-next v5 3/5] ethtool: netlink: add lightweight MSE reporting to LINKSTATE_GET Oleksij Rempel
2025-09-08 12:46 ` [PATCH net-next v5 4/5] net: phy: micrel: add MSE interface support for KSZ9477 family Oleksij Rempel
2025-09-08 12:46 ` [PATCH net-next v5 5/5] net: phy: dp83td510: add MSE interface support for 10BASE-T1L Oleksij Rempel
2025-09-12 2:18 ` [PATCH net-next v5 0/5] ethtool: introduce PHY MSE diagnostics UAPI and drivers Jakub Kicinski
2025-09-12 12:16 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915080720.17646515@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kernel@pengutronix.de \
--cc=kory.maincent@bootlin.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=roan@protonic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).