Re: [PATCH net-next] net: wan: framer: Add version sysfs attribute for the Lantiq PEF2256 framer

[Simon Horman <horms@kernel.org>]

On Sat, Sep 13, 2025 at 11:13:26AM +0200, Christophe Leroy wrote:
> Lantiq PEF2256 framer has some little differences in behaviour
> depending on its version.
> 
> Add a sysfs attribute to allow user applications to know the
> version.
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>

...

> @@ -114,6 +115,14 @@ enum pef2256_version pef2256_get_version(struct pef2256 *pef2256)
>  }
>  EXPORT_SYMBOL_GPL(pef2256_get_version);
>  
> +static ssize_t version_show(struct device *dev, struct device_attribute *attr, char *buf)
> +{
> +	struct pef2256 *pef2256 = dev_get_drvdata(dev);
> +
> +	return sysfs_emit(buf, "%s\n", pef2256->version_txt);
> +}
> +DEVICE_ATTR_RO(version);

Hi Christophe,

I think this can be: static DEVICE_ATTR_RO(version);

Flagged by Sparse.

> +
>  enum pef2256_gcm_config_item {
>  	PEF2256_GCM_CONFIG_1544000 = 0,
>  	PEF2256_GCM_CONFIG_2048000,

...