From: Rob Herring <robh@kernel.org>
To: "Bastien Curutchet (Schneider Electric)" <bastien.curutchet@bootlin.com>
Cc: "Woojung Huh" <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, "Andrew Lunn" <andrew@lunn.ch>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Marek Vasut" <marex@denx.de>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Pascal Eberhard" <pascal.eberhard@se.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/3] dt-bindings: net: dsa: microchip: Add strap description to set SPI mode
Date: Mon, 15 Sep 2025 16:10:36 -0500 [thread overview]
Message-ID: <20250915211036.GA3390851-robh@kernel.org> (raw)
In-Reply-To: <20250912-ksz-strap-pins-v2-2-6d97270c6926@bootlin.com>
On Fri, Sep 12, 2025 at 11:09:13AM +0200, Bastien Curutchet (Schneider Electric) wrote:
> At reset, KSZ8463 uses a strap-based configuration to set SPI as
> interface bus. If the required pull-ups/pull-downs are missing (by
> mistake or by design to save power) the pins may float and the
> configuration can go wrong preventing any communication with the switch.
>
> Add a 'reset' pinmux state
> Add a KSZ8463 specific strap description that can be used by the driver
> to drive the strap pins during reset. Two GPIOs are used. Users must
> describe either both of them or none of them.
>
> Signed-off-by: Bastien Curutchet (Schneider Electric) <bastien.curutchet@bootlin.com>
> ---
> .../devicetree/bindings/net/dsa/microchip,ksz.yaml | 24 ++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> index db8175b4ced6d136ba97c371b68ba993637e444a..099c6b373704427755c3d8cad4b1cd930219f2f2 100644
> --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> @@ -34,6 +34,13 @@ properties:
> - microchip,ksz8567
> - microchip,lan9646
>
> + pinctrl-names:
> + items:
> + - const: default
> + - const: reset
> + description:
> + Used during reset for strap configuration.
> +
> reset-gpios:
> description:
> Should be a gpio specifier for a reset line.
> @@ -139,6 +146,23 @@ allOf:
> should be provided externally.
> dependencies:
> microchip,rmii-clk-internal: [ethernet]
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: microchip,ksz8463
> + then:
> + properties:
> + strap-rxd0-gpios:
> + description:
> + RXD0 pin, used to select SPI as bus interface.
> + strap-rxd1-gpios:
> + description:
> + RXD1 pin, used to select SPI as bus interface.
> +
> +dependencies:
> + strap-rxd0-gpios: [ strap-rxd1-gpios ]
> + strap-rxd1-gpios: [ strap-rxd0-gpios ]
It would be simpler to define "strap-rxd-gpios" with a length of 2
entries:
straps-rxd-gpios:
minItems: 2
maxItems: 2
Rob
next prev parent reply other threads:[~2025-09-15 21:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 9:09 [PATCH net-next v2 0/3] net: dsa: microchip: Add strap description to set SPI as interface bus Bastien Curutchet (Schneider Electric)
2025-09-12 9:09 ` [PATCH net-next v2 1/3] dt-bindings: net: dsa: microchip: Group if clause under allOf tag Bastien Curutchet (Schneider Electric)
2025-09-15 21:12 ` Rob Herring (Arm)
2025-09-12 9:09 ` [PATCH net-next v2 2/3] dt-bindings: net: dsa: microchip: Add strap description to set SPI mode Bastien Curutchet (Schneider Electric)
2025-09-15 21:10 ` Rob Herring [this message]
2025-09-12 9:09 ` [PATCH net-next v2 3/3] net: dsa: microchip: Set SPI as bus interface during reset for KSZ8463 Bastien Curutchet
2025-09-15 22:00 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915211036.GA3390851-robh@kernel.org \
--to=robh@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=bastien.curutchet@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pascal.eberhard@se.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).