netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
	andrew+netdev@lunn.ch, horms@kernel.org, willemb@google.com,
	Raed Salem <raeds@nvidia.com>,
	Rahul Rameshbabu <rrameshbabu@nvidia.com>,
	Cosmin Ratiu <cratiu@nvidia.com>,
	Daniel Zahka <daniel.zahka@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next v12 19/19] net/mlx5e: Implement PSP key_rotate operation
Date: Mon, 15 Sep 2025 17:05:59 -0700	[thread overview]
Message-ID: <20250916000559.1320151-20-kuba@kernel.org> (raw)
In-Reply-To: <20250916000559.1320151-1-kuba@kernel.org>

From: Raed Salem <raeds@nvidia.com>

Implement .key_rotate operation where when invoked will cause the HW to use
a new master key to derive PSP spi/key pairs with complience with PSP spec.

Signed-off-by: Raed Salem <raeds@nvidia.com>
Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: Cosmin Ratiu <cratiu@nvidia.com>
Signed-off-by: Daniel Zahka <daniel.zahka@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
Notes:
    v1:
    - https://lore.kernel.org/netdev/20240510030435.120935-16-kuba@kernel.org/
---
 .../mellanox/mlx5/core/en_accel/psp.c         | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c
index 372513edfb92..b4cb131c5f81 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c
@@ -827,11 +827,34 @@ static void mlx5e_psp_assoc_del(struct psp_dev *psd, struct psp_assoc *pas)
 	atomic_dec(&psp->tx_key_cnt);
 }
 
+static int mlx5e_psp_rotate_key(struct mlx5_core_dev *mdev)
+{
+	u32 in[MLX5_ST_SZ_DW(psp_rotate_key_in)] = {};
+	u32 out[MLX5_ST_SZ_DW(psp_rotate_key_out)];
+
+	MLX5_SET(psp_rotate_key_in, in, opcode,
+		 MLX5_CMD_OP_PSP_ROTATE_KEY);
+
+	return mlx5_cmd_exec(mdev, in, sizeof(in), out, sizeof(out));
+}
+
+static int
+mlx5e_psp_key_rotate(struct psp_dev *psd, struct netlink_ext_ack *exack)
+{
+	struct mlx5e_priv *priv = netdev_priv(psd->main_netdev);
+
+	/* no support for protecting against external rotations */
+	psd->generation = 0;
+
+	return mlx5e_psp_rotate_key(priv->mdev);
+}
+
 static struct psp_dev_ops mlx5_psp_ops = {
 	.set_config   = mlx5e_psp_set_config,
 	.rx_spi_alloc = mlx5e_psp_rx_spi_alloc,
 	.tx_key_add   = mlx5e_psp_assoc_add,
 	.tx_key_del   = mlx5e_psp_assoc_del,
+	.key_rotate   = mlx5e_psp_key_rotate,
 };
 
 void mlx5e_psp_unregister(struct mlx5e_priv *priv)
-- 
2.51.0


      parent reply	other threads:[~2025-09-16  0:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-16  0:05 [PATCH net-next v12 00/19] add basic PSP encryption for TCP connections Jakub Kicinski
2025-09-16  0:05 ` [PATCH net-next v12 01/19] psp: add documentation Jakub Kicinski
2025-09-16  0:05 ` [PATCH net-next v12 02/19] psp: base PSP device support Jakub Kicinski
2025-09-16  0:05 ` [PATCH net-next v12 03/19] net: modify core data structures for PSP datapath support Jakub Kicinski
2025-09-16  0:05 ` [PATCH net-next v12 04/19] tcp: add datapath logic for PSP with inline key exchange Jakub Kicinski
2025-09-16  0:05 ` [PATCH net-next v12 05/19] psp: add op for rotation of device key Jakub Kicinski
2025-09-16  0:05 ` [PATCH net-next v12 06/19] net: move sk_validate_xmit_skb() to net/core/dev.c Jakub Kicinski
2025-09-16  0:05 ` [PATCH net-next v12 07/19] net: tcp: allow tcp_timewait_sock to validate skbs before handing to device Jakub Kicinski
2025-09-16  0:05 ` [PATCH net-next v12 08/19] net: psp: add socket security association code Jakub Kicinski
2025-09-16  0:05 ` [PATCH net-next v12 09/19] net: psp: update the TCP MSS to reflect PSP packet overhead Jakub Kicinski
2025-09-16  0:05 ` [PATCH net-next v12 10/19] psp: track generations of device key Jakub Kicinski
2025-09-16  0:05 ` [PATCH net-next v12 11/19] net/mlx5e: Support PSP offload functionality Jakub Kicinski
2025-09-16  0:05 ` [PATCH net-next v12 12/19] net/mlx5e: Implement PSP operations .assoc_add and .assoc_del Jakub Kicinski
2025-09-16  0:05 ` [PATCH net-next v12 13/19] psp: provide encapsulation helper for drivers Jakub Kicinski
2025-09-16  0:05 ` [PATCH net-next v12 14/19] net/mlx5e: Implement PSP Tx data path Jakub Kicinski
2025-09-16  0:05 ` [PATCH net-next v12 15/19] net/mlx5e: Add PSP steering in local NIC RX Jakub Kicinski
2025-09-16  0:05 ` [PATCH net-next v12 16/19] net/mlx5e: Configure PSP Rx flow steering rules Jakub Kicinski
2025-09-16  0:05 ` [PATCH net-next v12 17/19] psp: provide decapsulation and receive helper for drivers Jakub Kicinski
2025-09-16  0:05 ` [PATCH net-next v12 18/19] net/mlx5e: Add Rx data path offload Jakub Kicinski
2025-09-16  0:05 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250916000559.1320151-20-kuba@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=cratiu@nvidia.com \
    --cc=daniel.zahka@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=raeds@nvidia.com \
    --cc=rrameshbabu@nvidia.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).