From: xuanqiang.luo@linux.dev
To: edumazet@google.com, kuniyu@google.com
Cc: kerneljasonxing@gmail.com, davem@davemloft.net, kuba@kernel.org,
netdev@vger.kernel.org, Xuanqiang Luo <luoxuanqiang@kylinos.cn>
Subject: [PATCH net-next v2 0/3] net: Avoid ehash lookup races
Date: Tue, 16 Sep 2025 14:46:11 +0800 [thread overview]
Message-ID: <20250916064614.605075-1-xuanqiang.luo@linux.dev> (raw)
From: Xuanqiang Luo <luoxuanqiang@kylinos.cn>
After replacing R/W locks with RCU in commit 3ab5aee7fe84 ("net: Convert
TCP & DCCP hash tables to use RCU / hlist_nulls"), a race window emerged
during the switch from reqsk/sk to sk/tw.
Now that both timewait sock (tw) and full sock (sk) reside on the same
ehash chain, it is appropriate to introduce hlist_nulls replace
operations, to eliminate the race conditions caused by this window.
---
Changes:
v2:
* Patch 1
* Use WRITE_ONCE() to initialize old->pprev.
* Patch 2&3
* Optimize sk hashed check. Thanks Kuni for pointing it out!
v1: https://lore.kernel.org/all/20250915070308.111816-1-xuanqiang.luo@linux.dev/
Xuanqiang Luo (3):
rculist: Add __hlist_nulls_replace_rcu() and
hlist_nulls_replace_init_rcu()
inet: Avoid ehash lookup race in inet_ehash_insert()
inet: Avoid ehash lookup race in inet_twsk_hashdance_schedule()
include/linux/rculist_nulls.h | 61 +++++++++++++++++++++++++++++++++++
include/net/sock.h | 23 +++++++++++++
net/ipv4/inet_hashtables.c | 4 ++-
net/ipv4/inet_timewait_sock.c | 15 ++++-----
4 files changed, 93 insertions(+), 10 deletions(-)
--
2.25.1
next reply other threads:[~2025-09-16 6:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 6:46 xuanqiang.luo [this message]
2025-09-16 6:46 ` [PATCH net-next v2 1/3] rculist: Add __hlist_nulls_replace_rcu() and hlist_nulls_replace_init_rcu() xuanqiang.luo
2025-09-16 6:46 ` [PATCH net-next v2 2/3] inet: Avoid ehash lookup race in inet_ehash_insert() xuanqiang.luo
2025-09-16 6:46 ` [PATCH net-next v2 3/3] inet: Avoid ehash lookup race in inet_twsk_hashdance_schedule() xuanqiang.luo
2025-09-16 7:30 ` [PATCH net-next v2 0/3] net: Avoid ehash lookup races Eric Dumazet
2025-09-16 8:11 ` luoxuanqiang
2025-09-16 9:02 ` Eric Dumazet
2025-09-16 9:20 ` luoxuanqiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250916064614.605075-1-xuanqiang.luo@linux.dev \
--to=xuanqiang.luo@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=luoxuanqiang@kylinos.cn \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).