Re: [PATCH net-next 5/5] net: dsa: mv88e6xxx: move mv88e6xxx_hwtstamp_work() prototype

Russell King (Oracle)
2025-09-16T08:36:18Z

On Tue, Sep 16, 2025 at 11:09:03AM +0300, Vladimir Oltean wrote:
> On Mon, Sep 15, 2025 at 02:06:35PM +0100, Russell King (Oracle) wrote:
> > Since mv88e6xxx_hwtstamp_work() is defined in hwtstamp.c, its
> > prototype should be in hwtstamp.h, so move it there.
> >
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> > ---
>
> This leaves the shim definition (for when CONFIG_NET_DSA_MV88E6XXX_PTP
> is not defined) in ptp.h. It creates an inconsistency and potential
> problem - the same header should provide all definitions of the same
> function.

The only caller of mv88e6xxx_hwtstamp_work() is from ptp.c, and both
hwtstamp.c which provides this function and ptp.c are only built if
CONFIG_NET_DSA_MV88E6XXX_PTP is set. So, this shim serves no useful
purpose.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!