Re: [PATCH net-next 5/5] net: dsa: mv88e6xxx: move mv88e6xxx_hwtstamp_work() prototype

Vladimir Oltean
2025-09-16T08:09:08Z

On Mon, Sep 15, 2025 at 02:06:35PM +0100, Russell King (Oracle) wrote:
> Since mv88e6xxx_hwtstamp_work() is defined in hwtstamp.c, its
> prototype should be in hwtstamp.h, so move it there.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---

This leaves the shim definition (for when CONFIG_NET_DSA_MV88E6XXX_PTP
is not defined) in ptp.h. It creates an inconsistency and potential
problem - the same header should provide all definitions of the same
function.