Re: [PATCH net-next 5/5] net: dsa: mv88e6xxx: move mv88e6xxx_hwtstamp_work() prototype

Andrew Lunn
2025-09-16T12:46:11Z

> This leaves the shim definition (for when CONFIG_NET_DSA_MV88E6XXX_PTP
> is not defined) in ptp.h. It creates an inconsistency and potential
> problem - the same header should provide all definitions of the same
> function.

How big is the PTP code? We have added a lot of code to this driver
since PTP was added. I suspect the PTP code is now small compared to
the rest of the driver, so does it still make sense to have it
optional? Also once the PTP code gets moved into a library and shared
by the Marvell PHY driver and other Marvell MAC drivers, won't we have
an overall code shrink even when it is enabled in DSA?

Maybe it is time for CONFIG_NET_DSA_MV88E6XXX_PTP to go away?

Andrew