From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Paul Barker <paul@pbarker.dev>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Richard Cochran <richardcochran@gmail.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [net-next 1/6] net: rswitch: Move definition of S4 gPTP offset
Date: Tue, 16 Sep 2025 14:20:29 +0200 [thread overview]
Message-ID: <20250916122029.GC1045278@ragnatech.se> (raw)
In-Reply-To: <bff98e48-ae2c-489e-b422-3cae28bd0e16@lunn.ch>
On 2025-09-16 14:16:09 +0200, Andrew Lunn wrote:
> On Tue, Sep 16, 2025 at 12:10:50PM +0200, Niklas Söderlund wrote:
> > The files rcar_gen4_ptp.{c,h} implements an abstraction of the gPTP
> > support implemented together with different other IP blocks. The first
> > device added which supported this was RSWITCH on R-Car S4.
> >
> > While doing so the RSWITCH R-Car S4 specific offset was added to the
> > generic Gen4 gPTP header file. Move it to the RSWITCH driver to make it
> > clear it only applies to this driver.
>
> This is a nice simple patch to understand, which is good. But i do
> wounder about naming schemes. Since this is a RSWITCH define, should
> it use the RSWITCH_ prefix?
It could, I opted for the least disruptive path and just moved it as is.
Would you prefers I rename?
>
> Are there other implementations which have an equivalent of
> RCAR_GEN4_GPTP_OFFSET_S4? How are they named?
There are none, at least not so far as the RSWITCH IP are only available
on the R-Car S4 SoC.
>
> Andrew
--
Kind Regards,
Niklas Söderlund
next prev parent reply other threads:[~2025-09-16 12:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 10:10 [net-next 0/6] net: renesas: Cleanup usage of gPTP flags Niklas Söderlund
2025-09-16 10:10 ` [net-next 1/6] net: rswitch: Move definition of S4 gPTP offset Niklas Söderlund
2025-09-16 12:16 ` Andrew Lunn
2025-09-16 12:20 ` Niklas Söderlund [this message]
2025-09-16 10:10 ` [net-next 2/6] net: rcar_gen4_ptp: Move control fields to users Niklas Söderlund
2025-09-16 12:22 ` Andrew Lunn
2025-09-16 10:10 ` [net-next 3/6] net: rswitch: Use common defines for time stamping control Niklas Söderlund
2025-09-16 12:31 ` Andrew Lunn
2025-09-16 13:09 ` Niklas Söderlund
2025-09-16 10:10 ` [net-next 4/6] net: rtsn: " Niklas Söderlund
2025-09-16 10:10 ` [net-next 5/6] net: rcar_gen4_ptp: Remove unused defines Niklas Söderlund
2025-09-16 12:32 ` Andrew Lunn
2025-09-16 10:10 ` [net-next 6/6] net: ravb: Use common defines for time stamping control Niklas Söderlund
2025-09-16 12:38 ` Andrew Lunn
2025-09-16 13:08 ` Niklas Söderlund
2025-09-16 14:49 ` Andrew Lunn
2025-09-16 20:53 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250916122029.GC1045278@ragnatech.se \
--to=niklas.soderlund+renesas@ragnatech.se \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul@pbarker.dev \
--cc=richardcochran@gmail.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).