From: Jakub Kicinski <kuba@kernel.org>
To: Konrad Leszczynski <konrad.leszczynski@intel.com>
Cc: davem@davemloft.net, andrew+netdev@lunn.ch, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, cezary.rojewski@intel.com,
sebastian.basierski@intel.com,
Karol Jurczenia <karol.jurczenia@intel.com>
Subject: Re: [PATCH net v4 2/2] net: stmmac: check if interface is running before TC block setup
Date: Tue, 16 Sep 2025 16:25:40 -0700 [thread overview]
Message-ID: <20250916162540.66ae3091@kernel.org> (raw)
In-Reply-To: <20250916120932.217547-3-konrad.leszczynski@intel.com>
On Tue, 16 Sep 2025 14:09:32 +0200 Konrad Leszczynski wrote:
> If the interface is down before setting a TC block, the queues are already
> disabled and setup cannot proceed.
I asked for more details in the commit message earlier.
Also where did the Fixes tags go? The Fixes tags should only be removed
for the patches which end up going to net-next.
prev parent reply other threads:[~2025-09-16 23:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 12:09 [PATCH net v4 0/2] net: stmmac: misc fixes Konrad Leszczynski
2025-09-16 12:09 ` [PATCH net v4 1/2] net: stmmac: replace memcpy with ethtool_puts in ethtool Konrad Leszczynski
2025-09-16 16:45 ` Simon Horman
2025-09-16 17:12 ` Andrew Lunn
2025-09-16 23:25 ` Jakub Kicinski
2025-09-17 15:54 ` Tony Nguyen
2025-09-16 12:09 ` [PATCH net v4 2/2] net: stmmac: check if interface is running before TC block setup Konrad Leszczynski
2025-09-16 23:25 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250916162540.66ae3091@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cezary.rojewski@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=karol.jurczenia@intel.com \
--cc=konrad.leszczynski@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sebastian.basierski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).