netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
	Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	Donald Hunter <donald.hunter@gmail.com>,
	kernel@pengutronix.de,
	Dent Project <dentproject@linuxfoundation.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	linux-doc@vger.kernel.org, Kyle Swenson <kyle.swenson@est.tech>
Subject: Re: [PATCH net-next v3 0/5] net: pse-pd: pd692x0: Add permanent configuration management support
Date: Tue, 16 Sep 2025 16:54:40 -0700	[thread overview]
Message-ID: <20250916165440.3d4e498a@kernel.org> (raw)
In-Reply-To: <20250915-feature_poe_permanent_conf-v3-0-78871151088b@bootlin.com>

On Mon, 15 Sep 2025 19:06:25 +0200 Kory Maincent wrote:
> This patch series introduces a new devlink-conf uAPI to manage device
> configuration stored in non-volatile memory. This provides a standardized
> interface for devices that need to persist configuration changes across
> reboots. The uAPI is designed to be generic and can be used by any device
> driver that manages persistent configuration storage.
> 
> The permanent configuration allows settings to persist across device
> resets and power cycles, providing better control over PSE behavior
> in production environments.

I'm still unclear on the technical justification for this.
"There's a tool in another project which does it this way"
is not usually sufficient upstream. For better or worse we
like to re-implement things from first principles.

Could you succinctly explain why "saving config" can't be implemented
by some user space dumping out ethtool configuration, saving it under
/etc, and using that config after reboot. A'la iptables-save /
iptables-restore?

(I'll apply patch 3 now, looks like a nice cleanup)

  parent reply	other threads:[~2025-09-16 23:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-15 17:06 [PATCH net-next v3 0/5] net: pse-pd: pd692x0: Add permanent configuration management support Kory Maincent
2025-09-15 17:06 ` [PATCH net-next v3 1/5] net: pse-pd: pd692x0: Replace __free macro with explicit kfree calls Kory Maincent
2025-09-15 17:06 ` [PATCH net-next v3 2/5] net: pse-pd: pd692x0: Separate configuration parsing from hardware setup Kory Maincent
2025-09-15 17:06 ` [PATCH net-next v3 3/5] docs: devlink: Sort table of contents alphabetically Kory Maincent
2025-09-15 17:06 ` [PATCH net-next v3 4/5] devlink: Add devlink-conf uAPI for NV memory management Kory Maincent
2025-09-15 17:06 ` [PATCH net-next v3 5/5] net: pse-pd: pd692x0: Add devlink interface for configuration save/reset Kory Maincent
2025-09-16 23:54 ` Jakub Kicinski [this message]
2025-09-17  9:46   ` [PATCH net-next v3 0/5] net: pse-pd: pd692x0: Add permanent configuration management support Kory Maincent
2025-09-17 21:19     ` Jakub Kicinski
2025-09-22 16:20       ` Kory Maincent
2025-09-22 18:02         ` Jakub Kicinski
2025-09-23  9:04           ` Kory Maincent
2025-09-17  0:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250916165440.3d4e498a@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=dentproject@linuxfoundation.org \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jiri@resnulli.us \
    --cc=kernel@pengutronix.de \
    --cc=kory.maincent@bootlin.com \
    --cc=kyle.swenson@est.tech \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).