From: Vladimir Oltean <olteanv@gmail.com>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Simon Horman <horms@kernel.org>,
"Chester A. Unal" <chester.a.unal@arinc9.com>,
Daniel Golle <daniel@makrotopia.org>,
DENG Qingfang <dqfext@gmail.com>,
Sean Wang <sean.wang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH v18 0/8] net: dsa: Add Airoha AN8855 support
Date: Wed, 17 Sep 2025 12:28:07 +0300 [thread overview]
Message-ID: <20250917092807.uui2qwva2sqbe6sp@skbuf> (raw)
In-Reply-To: <20250915104545.1742-1-ansuelsmth@gmail.com>
On Mon, Sep 15, 2025 at 12:45:36PM +0200, Christian Marangi wrote:
> It's conceptually similar to mediatek switch but register and bits
> are different. And there is massive list of register for the PCS
> configuration.
> Saddly for that part we have absolutely NO documentation currently.
Please add in the next revision a more convincing argument for not
reusing the mt7530 driver control flow. Regmap fields can abstract a
lot, and the driver can select a completely different phylink_pcs for
different hardware.
I don't see in the short change log included here any mentions related
to the mt7530, but I'm not going to search the mailing lists since Nov
2024 for any previous discussions about this...
Also, let's try not to reach v20.. Please try to collect a full round of
feedback from people who commented before when submitting a new version,
pinging people if necessary. You want to make sure that their previous
feedback was addressed.
> TEST: lan2: Multicast IPv4 to joined group [ OK ]
> TEST: lan2: Multicast IPv4 to unknown group [XFAIL]
> reception succeeded, but should have failed
> TEST: lan2: Multicast IPv4 to unknown group, promisc [ OK ]
> TEST: lan2: Multicast IPv4 to unknown group, allmulti [ OK ]
> TEST: lan2: Multicast IPv6 to joined group [ OK ]
> TEST: lan2: Multicast IPv6 to unknown group [XFAIL]
> reception succeeded, but should have failed
> TEST: lan2: Multicast IPv6 to unknown group, promisc [ OK ]
> TEST: lan2: Multicast IPv6 to unknown group, allmulti [ OK ]
> TEST: lan2: 1588v2 over L2 transport, Sync [ OK ]
> TEST: lan2: 1588v2 over L2 transport, Follow-Up [ OK ]
> TEST: lan2: 1588v2 over L2 transport, Peer Delay Request [ OK ]
> TEST: lan2: 1588v2 over IPv4, Sync [FAIL]
> reception failed
> TEST: lan2: 1588v2 over IPv4, Follow-Up [FAIL]
> reception failed
> TEST: lan2: 1588v2 over IPv4, Peer Delay Request [FAIL]
> reception failed
> TEST: lan2: 1588v2 over IPv6, Sync [FAIL]
> reception failed
> TEST: lan2: 1588v2 over IPv6, Follow-Up [FAIL]
> reception failed
> TEST: lan2: 1588v2 over IPv6, Peer Delay Request [FAIL]
> reception failed
Do you know why it won't receive PTP over IP? It seems strange, given it
receives other IP multicast (even unregistered). Is it a hardware or a
software drop? What port counters increment? Does it drop PTP over IP
only on local termination, or does it also fail to forward it? What
about the packet makes the switch drop it?
> TEST: vlan_filtering=1 bridge: Multicast IPv6 to unknown group, promisc [ OK ]
> TEST: vlan_filtering=1 bridge: Multicast IPv6 to unknown group, allmulti [ OK ]
> TEST: VLAN upper: Unicast IPv4 to primary MAC address [ OK ]
> TEST: VLAN upper: Unicast IPv4 to macvlan MAC address [ OK ]
> TEST: VLAN upper: Unicast IPv4 to unknown MAC address [ OK ]
> TEST: VLAN upper: Unicast IPv4 to unknown MAC address, promisc [ OK ]
> TEST: VLAN upper: Unicast IPv4 to unknown MAC address, allmulti [ OK ]
> TEST: VLAN upper: Multicast IPv4 to joined group [ OK ]
> TEST: VLAN upper: Multicast IPv4 to unknown group [XFAIL]
> reception succeeded, but should have failed
> TEST: VLAN upper: Multicast IPv4 to unknown group, promisc [ OK ]
> TEST: VLAN upper: Multicast IPv4 to unknown group, allmulti [ OK ]
> TEST: VLAN upper: Multicast IPv6 to joined group [ OK ]
> TEST: VLAN upper: Multicast IPv6 to unknown group [XFAIL]
> reception succeeded, but should have failed
> TEST: VLAN upper: Multicast IPv6 to unknown group, promisc [ OK ]
> TEST: VLAN upper: Multicast IPv6 to unknown group, allmulti [ OK ]
> TEST: VLAN upper: 1588v2 over L2 transport, Sync [ OK ]
> TEST: VLAN upper: 1588v2 over L2 transport, Follow-Up [FAIL]
> reception failed
> TEST: VLAN upper: 1588v2 over L2 transport, Peer Delay Request [ OK ]
> TEST: VLAN upper: 1588v2 over IPv4, Sync [FAIL]
> reception failed
> ;TEST: VLAN upper: 1588v2 over IPv4, Follow-Up [FAIL]
> reception failed
> TEST: VLAN upper: 1588v2 over IPv4, Peer Delay Request [FAIL]
> reception failed
> TEST: VLAN upper: 1588v2 over IPv6, Sync [FAIL]
> reception failed
> TEST: VLAN upper: 1588v2 over IPv6, Follow-Up [FAIL]
> reception failed
> TEST: VLAN upper: 1588v2 over IPv6, Peer Delay Request [FAIL]
> reception failed
The same thing happens with VLAN too...
> TEST: VLAN over vlan_filtering=0 bridged port: Multicast IPv4 to joined group [ OK ]
> TEST: VLAN over vlan_filtering=0 bridged port: Multicast IPv4 to unknown group [XFAIL]
> reception succeeded, but should have failed
> TEST: VLAN over vlan_filtering=0 bridged port: Multicast IPv4 to unknown group, promisc [ OK ]
> TEST: VLAN over vlan_filtering=0 bridged port: Multicast IPv4 to unknown group, allmulti [ OK ]
> TEST: VLAN over vlan_filtering=0 bridged port: Multicast IPv6 to joined group [ OK ]
> TEST: VLAN over vlan_filtering=0 bridged port: Multicast IPv6 to unknown group [XFAIL]
> reception succeeded, but should have failed
> TEST: VLAN over vlan_filtering=0 bridged port: Multicast IPv6 to unknown group, promisc [ OK ]
> TEST: VLAN over vlan_filtering=0 bridged port: Multicast IPv6 to unknown group, allmulti [ OK ]
> TEST: VLAN over vlan_filtering=0 bridged port: 1588v2 over L2 transport, Sync [ OK ]
> TEST: VLAN over vlan_filtering=0 bridged port: 1588v2 over L2 transport, Follow-Up [ OK ]
> TEST: VLAN over vlan_filtering=0 bridged port: 1588v2 over L2 transport, Peer Delay Request [ OK ]
> TEST: VLAN over vlan_filtering=0 bridged port: 1588v2 over IPv4, Sync [FAIL]
> reception failed
> TEST: VLAN over vlan_filtering=0 bridged port: 1588v2 over IPv4, Follow-Up [FAIL]
> reception failed
> TEST: VLAN over vlan_filtering=0 bridged port: 1588v2 over IPv4, Peer Delay Request [FAIL]
> reception failed
> TEST: VLAN over vlan_filtering=0 bridged port: 1588v2 over IPv6, Sync [FAIL]
> reception failed
> TEST: VLAN over vlan_filtering=0 bridged port: 1588v2 over IPv6, Follow-Up [FAIL]
> reception failed
> TEST: VLAN over vlan_filtering=0 bridged port: 1588v2 over IPv6, Peer Delay Request [FAIL]
> reception failed
> TEST: VLAN over vlan_filtering=1 bridged port: Multicast IPv4 to joined group [ OK ]
> TEST: VLAN over vlan_filtering=1 bridged port: Multicast IPv4 to unknown group [XFAIL]
> reception succeeded, but should have failed
> TEST: VLAN over vlan_filtering=1 bridged port: Multicast IPv4 to unknown group, promisc [ OK ]
> TEST: VLAN over vlan_filtering=1 bridged port: Multicast IPv4 to unknown group, allmulti [ OK ]
> TEST: VLAN over vlan_filtering=1 bridged port: Multicast IPv6 to joined group [ OK ]
> TEST: VLAN over vlan_filtering=1 bridged port: Multicast IPv6 to unknown group [XFAIL]
> reception succeeded, but should have failed
> TEST: VLAN over vlan_filtering=1 bridged port: Multicast IPv6 to unknown group, promisc [ OK ]
> TEST: VLAN over vlan_filtering=1 bridged port: Multicast IPv6 to unknown group, allmulti [ OK ]
> TEST: VLAN over vlan_filtering=1 bridged port: 1588v2 over L2 transport, Sync [ OK ]
> TEST: VLAN over vlan_filtering=1 bridged port: 1588v2 over L2 transport, Follow-Up [ OK ]
> TEST: VLAN over vlan_filtering=1 bridged port: 1588v2 over L2 transport, Peer Delay Request [ OK ]
> TEST: VLAN over vlan_filtering=1 bridged port: 1588v2 over IPv4, Sync [FAIL]
> reception failed
> TEST: VLAN over vlan_filtering=1 bridged port: 1588v2 over IPv4, Follow-Up [FAIL]
> reception failed
> TEST: VLAN over vlan_filtering=1 bridged port: 1588v2 over IPv4, Peer Delay Request [FAIL]
> reception failed
> TEST: VLAN over vlan_filtering=1 bridged port: 1588v2 over IPv6, Sync [FAIL]
> reception failed
> TEST: VLAN over vlan_filtering=1 bridged port: 1588v2 over IPv6, Follow-Up [FAIL]
> reception failed
> TEST: VLAN over vlan_filtering=1 bridged port: 1588v2 over IPv6, Peer Delay Request [FAIL]
> reception failed
And over bridge ports...
next prev parent reply other threads:[~2025-09-17 9:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 10:45 [net-next PATCH v18 0/8] net: dsa: Add Airoha AN8855 support Christian Marangi
2025-09-15 10:45 ` [net-next PATCH v18 1/8] dt-bindings: net: dsa: Document support for Airoha AN8855 DSA Switch Christian Marangi
2025-09-15 10:45 ` [net-next PATCH v18 2/8] dt-bindings: net: Document support for AN8855 Switch Internal PHY Christian Marangi
2025-09-15 10:45 ` [net-next PATCH v18 3/8] dt-bindings: mfd: Document support for Airoha AN8855 Switch SoC Christian Marangi
2025-09-15 17:01 ` Rob Herring (Arm)
2025-09-15 20:19 ` Rob Herring
2025-09-15 23:53 ` Christian Marangi
2025-09-17 10:37 ` Vladimir Oltean
2025-09-15 10:45 ` [net-next PATCH v18 4/8] net: dsa: tag_mtk: add Airoha variant usage of this TAG Christian Marangi
2025-09-17 9:35 ` Vladimir Oltean
2025-09-17 9:42 ` Christian Marangi
2025-09-17 10:03 ` Vladimir Oltean
2025-09-15 10:45 ` [net-next PATCH v18 5/8] net: dsa: Add Airoha AN8855 5-Port Gigabit DSA Switch driver Christian Marangi
2025-09-17 10:43 ` Vladimir Oltean
2025-09-15 10:45 ` [net-next PATCH v18 6/8] mfd: an8855: Add support for Airoha AN8855 Switch MFD Christian Marangi
2025-09-17 9:46 ` Vladimir Oltean
2025-09-17 10:11 ` Vladimir Oltean
2025-09-15 10:45 ` [net-next PATCH v18 7/8] net: phy: Add Airoha AN8855 Internal Switch Gigabit PHY Christian Marangi
2025-09-15 10:45 ` [net-next PATCH v18 8/8] MAINTAINERS: add myself as maintainer for AN8855 Christian Marangi
2025-09-17 9:28 ` Vladimir Oltean [this message]
2025-09-17 9:40 ` [net-next PATCH v18 0/8] net: dsa: Add Airoha AN8855 support Christian Marangi
2025-09-17 10:10 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917092807.uui2qwva2sqbe6sp@skbuf \
--to=olteanv@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=chester.a.unal@arinc9.com \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).