From: Stephen Hemminger <stephen@networkplumber.org>
To: Petr Malat <oss@malat.biz>
Cc: netdev@vger.kernel.org, sgoutham@marvell.com,
lcherian@marvell.com, gakula@marvell.com, jerinj@marvell.com,
sbhatta@marvell.com
Subject: Re: [PATCH] ethernet: rvu-af: Remove slash from the driver name
Date: Wed, 17 Sep 2025 11:37:10 -0700 [thread overview]
Message-ID: <20250917113710.75b5f9db@hermes.local> (raw)
In-Reply-To: <20250917071229.1742013-1-oss@malat.biz>
On Wed, 17 Sep 2025 09:12:30 +0200
Petr Malat <oss@malat.biz> wrote:
> Having a slash in the driver name leads to EIO being returned while
> reading /sys/module/rvu_af/drivers content.
>
> Remove DRV_STRING as it's not used anywhere.
>
> Signed-off-by: Petr Malat <oss@malat.biz>
> ---
> drivers/net/ethernet/marvell/octeontx2/af/cgx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
> index 0c46ba8a5adc..69324ae09397 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
> @@ -21,8 +21,7 @@
> #include "rvu.h"
> #include "lmac_common.h"
>
> -#define DRV_NAME "Marvell-CGX/RPM"
> -#define DRV_STRING "Marvell CGX/RPM Driver"
> +#define DRV_NAME "Marvell-CGX-RPM"
>
> #define CGX_RX_STAT_GLOBAL_INDEX 9
>
Please add
Fixes: 91c6945ea1f9 ("octeontx2-af: cn10k: Add RPM MAC support")
next prev parent reply other threads:[~2025-09-17 18:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 7:12 [PATCH] ethernet: rvu-af: Remove slash from the driver name Petr Malat
2025-09-17 16:06 ` Andrew Lunn
2025-09-17 18:37 ` Stephen Hemminger [this message]
2025-09-18 15:21 ` [PATCH net v2] " Petr Malat
2025-09-19 17:10 ` Simon Horman
2025-09-20 0:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917113710.75b5f9db@hermes.local \
--to=stephen@networkplumber.org \
--cc=gakula@marvell.com \
--cc=jerinj@marvell.com \
--cc=lcherian@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=oss@malat.biz \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).