From: Simon Horman <horms@kernel.org>
To: Sathesh B Edara <sedara@marvell.com>
Cc: linux-kernel@vger.kernel.org, sburla@marvell.com,
vburru@marvell.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
hgani@marvell.com, andrew@lunn.ch, srasheed@marvell.com
Subject: Re: [net PATCH v2] octeon_ep: Clear VF info at PF when VF driver is removed
Date: Wed, 17 Sep 2025 12:55:42 +0100 [thread overview]
Message-ID: <20250917115542.GA394836@horms.kernel.org> (raw)
In-Reply-To: <20250916131225.21589-1-sedara@marvell.com>
On Tue, Sep 16, 2025 at 06:12:25AM -0700, Sathesh B Edara wrote:
> When a VF (Virtual Function) driver is removed, the PF (Physical Function)
> driver continues to retain stale VF-specific information. This can lead to
> inconsistencies or unexpected behavior when the VF is re-initialized or
> reassigned.
>
> This patch ensures that the PF driver clears the corresponding VF info
> when the VF driver is removed, maintaining a clean state and preventing
> potential issues.
>
> Fixes: cde29af9e68e ("octeon_ep: add PF-VF mailbox communication")
> Signed-off-by: Sathesh B Edara <sedara@marvell.com>
> ---
> Changes:
> V2:
> - Commit header format corrected.
Hi,
I feel that I must be missing something terribly obvious.
But this patch seems to be a subset of the one at the link below.
* [net PATCH v2] octeon_ep: fix VF MAC address lifecycle handling
https://lore.kernel.org/netdev/20250916133207.21737-1-sedara@marvell.com/
>
> drivers/net/ethernet/marvell/octeon_ep/octep_pfvf_mbox.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_pfvf_mbox.c b/drivers/net/ethernet/marvell/octeon_ep/octep_pfvf_mbox.c
> index ebecdd29f3bd..f2759d2073d1 100644
> --- a/drivers/net/ethernet/marvell/octeon_ep/octep_pfvf_mbox.c
> +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_pfvf_mbox.c
> @@ -205,6 +205,8 @@ static void octep_pfvf_dev_remove(struct octep_device *oct, u32 vf_id,
> {
> int err;
>
> + /* Reset VF-specific information maintained by the PF */
> + memset(&oct->vf_info[vf_id], 0, sizeof(struct octep_pfvf_info));
> err = octep_ctrl_net_dev_remove(oct, vf_id);
> if (err) {
> rsp->s.type = OCTEP_PFVF_MBOX_TYPE_RSP_NACK;
> --
> 2.36.0
>
>
next prev parent reply other threads:[~2025-09-17 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 13:12 [net PATCH v2] octeon_ep: Clear VF info at PF when VF driver is removed Sathesh B Edara
2025-09-17 11:55 ` Simon Horman [this message]
2025-09-17 12:24 ` [EXTERNAL] " Sathesh B Edara
2025-09-17 14:39 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917115542.GA394836@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hgani@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sburla@marvell.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=vburru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).