From: Stephen Hemminger <stephen@networkplumber.org>
To: David Wilder <wilder@us.ibm.com>
Cc: netdev@vger.kernel.org, jv@jvosburgh.net,
pradeeps@linux.vnet.ibm.com, pradeep@us.ibm.com,
i.maximets@ovn.org, amorenoz@redhat.com, haliu@redhat.com,
dsahern@gmail.com
Subject: Re: [PATCH iproute2-next v5 1/1] iproute: Extend bonding's "arp_ip_target" parameter to add vlan tags.
Date: Wed, 17 Sep 2025 12:00:26 -0700 [thread overview]
Message-ID: <20250917120026.7601b13a@hermes.local> (raw)
In-Reply-To: <20250902211705.2335007-2-wilder@us.ibm.com>
On Tue, 2 Sep 2025 14:15:52 -0700
David Wilder <wilder@us.ibm.com> wrote:
> for (i = 0; target && i < BOND_MAX_ARP_TARGETS; i++) {
> - __u32 addr = get_addr32(target);
> + struct __attribute__((packed)) Data {
> + __u32 addr;
> + struct bond_vlan_tag vlans[];
> + } data;
Do not add unnecessary packed attribute. The compiler won't pad.
Do not use Capitalization on structure types.
You can just use:
struct {
prev parent reply other threads:[~2025-09-17 19:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 21:15 [PATCH iproute2-next v5 0/1] iproute2-next: Extending bonding's arp_ip_target to include a list of vlan tags David Wilder
2025-09-02 21:15 ` [PATCH iproute2-next v5 1/1] iproute: Extend bonding's "arp_ip_target" parameter to add " David Wilder
2025-09-16 15:34 ` Stephen Hemminger
2025-09-17 19:00 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917120026.7601b13a@hermes.local \
--to=stephen@networkplumber.org \
--cc=amorenoz@redhat.com \
--cc=dsahern@gmail.com \
--cc=haliu@redhat.com \
--cc=i.maximets@ovn.org \
--cc=jv@jvosburgh.net \
--cc=netdev@vger.kernel.org \
--cc=pradeep@us.ibm.com \
--cc=pradeeps@linux.vnet.ibm.com \
--cc=wilder@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).