From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 195BF31619D; Wed, 17 Sep 2025 12:53:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758113632; cv=none; b=JWlfvvttPZBjMCSnFjWfZYcnZHiZ9NwGKm2/mc0L8lUbD/vHiferV0Eu1zCgMcd7ExFTG5P4p0ZqJdRcUtALfMRgZMGTGyZRg7gQspM5yzQRxiOjD7A9YDWcJtNMyGQUKiE0iQN4LGds+yAgwvyz8Ux/lm44WIf6BUaLMu4Sc5E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758113632; c=relaxed/simple; bh=AYqrijFFPyOg6oTn1oHffDdanbDNoSAhEnePUl8ItdY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=da5oix5aFpf/AfDvkZzDs+ZCGvqe3mflGUekhYOdEs19kbepz4dInrE2LkL69CmA3Ndbn7+S7zBtxt6HO+8ux3PXDp63BMF8EyvtTrgRBb3RRzx2lJVaXKRnQ+SmZs0517P0OPB4f9ZlPLZVoGlX+ZlwjKja4d+622x6GSRaj90= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ShOaqYbb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ShOaqYbb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49E8BC4CEF0; Wed, 17 Sep 2025 12:53:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758113631; bh=AYqrijFFPyOg6oTn1oHffDdanbDNoSAhEnePUl8ItdY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ShOaqYbbqmk5e5akA4q2e2Xkei7t3KSsGI2knYNQKz/8gHiYse+MUUyjwpyHzQ5+N 9fSUp9EJFwQWbo9WljLYcvAsRbQWcHpRSUCM5MK+/AA+F2c3y6H9bgPMBryfsdjnCM 87oy58EyxolShT+x7iQy5LDZuqFv0dsKM9nwNeX4VMs85evwAF/VI81irLx++AUp1K PgzdNd9fK9UlM3t+yTzyTArNeOWeTe+4HbFW3v/UOsX9nflfMHl1raVDWS3Bb/Dhv0 fbEJ3o8qHf0ijqOznZ0jUwEVeRKTyaOSSfQ2NIrdhDAZgfkkoQvq0MQBp4kvkgIbQA CRqWn0aZJHLfg== Date: Wed, 17 Sep 2025 13:53:45 +0100 From: Simon Horman To: Tariq Toukan Cc: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" , Jiri Pirko , Jonathan Corbet , Leon Romanovsky , Jason Gunthorpe , Saeed Mahameed , Mark Bloch , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, Gal Pressman , Cosmin Ratiu , Dragos Tatulea , Jiri Pirko , Jason Gunthorpe Subject: Re: [PATCH net-next V2 03/10] net/mlx5e: Remove unused 'xsk' param of mlx5e_build_xdpsq_param Message-ID: <20250917125345.GD394836@horms.kernel.org> References: <1758031904-634231-1-git-send-email-tariqt@nvidia.com> <1758031904-634231-4-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1758031904-634231-4-git-send-email-tariqt@nvidia.com> On Tue, Sep 16, 2025 at 05:11:37PM +0300, Tariq Toukan wrote: > From: Cosmin Ratiu > > This was added in commit [1], but its only use removed in commit [2]. > The parameter is unused, so remove it from the function parameter list. > > [1] commit 9ded70fa1d81 ("net/mlx5e: Don't prefill WQEs in XDP SQ in the > multi buffer mode") > [2] commit 1a9304859b3a ("net/mlx5: XDP, Enable TX side XDP multi-buffer > support") > Signed-off-by: Cosmin Ratiu > Reviewed-by: Dragos Tatulea > Signed-off-by: Tariq Toukan Reviewed-by: Simon Horman