From: Jakub Kicinski <kuba@kernel.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: <netdev@vger.kernel.org>, "'Andrew Lunn'" <andrew+netdev@lunn.ch>,
"'David S. Miller'" <davem@davemloft.net>,
"'Eric Dumazet'" <edumazet@google.com>,
"'Paolo Abeni'" <pabeni@redhat.com>,
"'Simon Horman'" <horms@kernel.org>,
"'Alexander Lobakin'" <aleksander.lobakin@intel.com>,
"'Mengyuan Lou'" <mengyuanlou@net-swift.com>
Subject: Re: [PATCH net-next v4 1/2] net: libwx: support multiple RSS for every pool
Date: Wed, 17 Sep 2025 14:13:13 -0700 [thread overview]
Message-ID: <20250917141313.43b71217@kernel.org> (raw)
In-Reply-To: <039301dc27a6$194e79a0$4beb6ce0$@trustnetic.com>
On Wed, 17 Sep 2025 15:38:45 +0800 Jiawen Wu wrote:
> > > Deleting VFs will reset these configurations.
> >
> > You shouldn't reset user-set configuration of the PF when SR-IOV
> > is disabled.
>
> But the maximum queue number of PF is different when SRIOV is
> enabled or disabled?
>
> And for the global RSS table (non SR-IOV mode) or multiple RSS table
> (SR-IOV mode), the table size is different on hardware design.
>
> How could I keep the RSS redirection table during the mode switching?
Only if the user requested a particular config.
If netif_is_rxfh_configured() returns true and the RSS table contains
the ring you're trying to disable you should reject the attempt to
enable SRIOV.
For the change in table size you can just reject if
netif_is_rxfh_configured() for simplicity (user can reset the table using
ethtool -X $ifc default
You could support "shrinking" the table if both sub-tables are
identical. But IDK if its worth the effort. Setting custom indir tables
is fairly rare.
next prev parent reply other threads:[~2025-09-17 21:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 6:23 [PATCH net-next v4 0/2] net: wangxun: support to configure RSS Jiawen Wu
2025-09-12 6:23 ` [PATCH net-next v4 1/2] net: libwx: support multiple RSS for every pool Jiawen Wu
2025-09-16 1:01 ` Jakub Kicinski
2025-09-17 1:51 ` Jiawen Wu
2025-09-17 2:25 ` Jakub Kicinski
2025-09-17 7:38 ` Jiawen Wu
2025-09-17 21:13 ` Jakub Kicinski [this message]
2025-09-12 6:23 ` [PATCH net-next v4 2/2] net: wangxun: add RSS reta and rxfh fields support Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917141313.43b71217@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiawenwu@trustnetic.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).