From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, alexanderduyck@fb.com,
lee@trager.us
Subject: Re: [PATCH net-next v3 8/9] eth: fbnic: report FW uptime in health diagnose
Date: Wed, 17 Sep 2025 17:08:54 +0100 [thread overview]
Message-ID: <20250917160854.GP394836@horms.kernel.org> (raw)
In-Reply-To: <20250916231420.1693955-9-kuba@kernel.org>
On Tue, Sep 16, 2025 at 04:14:19PM -0700, Jakub Kicinski wrote:
> FW crashes are detected based on uptime going back, expose the uptime
> via devlink health diagnose.
>
> $ devlink -j health diagnose pci/0000:01:00.0 reporter fw
> {"last_heartbeat":{"fw_uptime":{"sec":201,"msec":76}}}
> $ devlink -j health diagnose pci/0000:01:00.0 reporter fw
> last_heartbeat:
> fw_uptime:
> sec: 201 msec: 76
>
> Reviewed-by: Lee Trager <lee@trager.us>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-09-17 16:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 23:14 [PATCH net-next v3 0/9] eth: fbnic: add devlink health support for FW crashes and OTP mem corruptions Jakub Kicinski
2025-09-16 23:14 ` [PATCH net-next v3 1/9] eth: fbnic: make fbnic_fw_log_write() parameter const Jakub Kicinski
2025-09-16 23:14 ` [PATCH net-next v3 2/9] eth: fbnic: use fw uptime to detect fw crashes Jakub Kicinski
2025-09-16 23:14 ` [PATCH net-next v3 3/9] eth: fbnic: factor out clearing the action TCAM Jakub Kicinski
2025-09-16 23:14 ` [PATCH net-next v3 4/9] eth: fbnic: reprogram TCAMs after FW crash Jakub Kicinski
2025-09-16 23:14 ` [PATCH net-next v3 5/9] eth: fbnic: support allocating FW completions with extra space Jakub Kicinski
2025-09-16 23:14 ` [PATCH net-next v3 6/9] eth: fbnic: support FW communication for core dump Jakub Kicinski
2025-09-16 23:14 ` [PATCH net-next v3 7/9] eth: fbnic: add FW health reporter Jakub Kicinski
2025-09-16 23:14 ` [PATCH net-next v3 8/9] eth: fbnic: report FW uptime in health diagnose Jakub Kicinski
2025-09-17 16:08 ` Simon Horman [this message]
2025-09-16 23:14 ` [PATCH net-next v3 9/9] eth: fbnic: add OTP health reporter Jakub Kicinski
2025-09-17 16:09 ` Simon Horman
2025-09-18 10:20 ` [PATCH net-next v3 0/9] eth: fbnic: add devlink health support for FW crashes and OTP mem corruptions patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917160854.GP394836@horms.kernel.org \
--to=horms@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=lee@trager.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).